On the patron clubs page, the clubs and club templates are each displayed in a paginated DataTable. JavaScript-driven controls in these tables don't work because the event handler doesn't take into account that the HTML elements may not be present in the initial page.
Created attachment 118876 [details] [review] Bug 28043: Some patron clubs operations don't work from later pages of results This page changes the way event handlers are defined for some operations on the patron clubs page. These changes make it possible for the controls to work on multi-page tables of clubs. To test, apply the patch and got to Tools -> Patron clubs. - If necessary, add enough patron club templates and patron clubs that there are more than 10 of each. - Click to the second page of club templates and try to delete a template. It should work correctly. - Click to the second page of clubs and try to delete a club. It should work correctly. - Add one or more patrons to a club (from the checkout or patron details page). - Click to the second page of clubs and try the "Search to hold" menu item. It should redirect you to the search page. - After entering a search, the results page should include "Place hold for <club>" links with each result.
Created attachment 118883 [details] [review] Bug 28043: Some patron clubs operations don't work from later pages of results To test, apply the patch and got to Tools -> Patron clubs. - If necessary, add enough patron club templates and patron clubs that there are more than 10 of each. - Click to the second page of club templates and try to delete a template. It should work correctly. - Click to the second page of clubs and try to delete a club. It should work correctly. - Add one or more patrons to a club (from the checkout or patron details page). - Click to the second page of clubs and try the "Search to hold" menu item. It should redirect you to the search page. - After entering a search, the results page should include "Place hold for <club>" links with each result.
Created attachment 118890 [details] [review] Bug 28043: Some patron clubs operations don't work from later pages of results This page changes the way event handlers are defined for some operations on the patron clubs page. These changes make it possible for the controls to work on multi-page tables of clubs. To test, apply the patch and got to Tools -> Patron clubs. - If necessary, add enough patron club templates and patron clubs that there are more than 10 of each. - Click to the second page of club templates and try to delete a template. It should work correctly. - Click to the second page of clubs and try to delete a club. It should work correctly. - Add one or more patrons to a club (from the checkout or patron details page). - Click to the second page of clubs and try the "Search to hold" menu item. It should redirect you to the search page. - After entering a search, the results page should include "Place hold for <club>" links with each result. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.05
Pushed to 20.05.x for 20.05.11
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.