Bug 28050 - SIP doesn't handle incorrect locations in CP field
Summary: SIP doesn't handle incorrect locations in CP field
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-29 14:57 UTC by Nick Clemens (kidclamp)
Modified: 2021-03-29 14:57 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2021-03-29 14:57:33 UTC 
In AddReturn we check that the branch for a return exists and force to the userenv if it does not.

In SIP we accept the incoming field from CP in a 93 message with no checking.

This can create a strange situation where holds are marked as 'In transit'

To recreate:
1 - Place a hold for a patron on an item in your catalog
2 - Use the sip cli emulator with a bad location code to check in that item
perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CLP -m checkin --item TESTER
3 - Note the typoed 'CLP' instead of 'CPL'
4 - Check the hold in the staff client - it is in transit