Value are missing in unimarc_field_135a.tt cf: https://www.transition-bibliographique.fr/wp-content/uploads/2018/07/B135-6-2010.pdf
Created attachment 119117 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a To test: 1) Apply patch to an UNIMARC system 2) Add a notice 3) Use 135 field tag editor 4) plugin is working with new value
Created attachment 120293 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a To test: 1) Apply patch to an UNIMARC system 2) Add a notice 3) Use 135 field tag editor 4) plugin is working with new value
Created attachment 124464 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a This patch add more values to selection of 135a in UNIMARC Test Plan: 1) Add on default framework the field 135a and check the Editor option 2) Set on plugin section the value of 3) Open cataloguing editor and use 135 field tag editor to select a value 4) Apply patch 5) Open cataloguing editor and use 135 field tag editor to select a value, after patch you have more options to select Signed-off-by: George Veranis <gveranis@dataly.gr>
Created attachment 124465 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a This patch add more values to selection of 135a in UNIMARC Test Plan: 1) Add on default framework the field 135a and check the Editor option 2) Set on plugin section the value of unimarc_field_135a.pl 3) Open cataloguing editor and use 135 field tag editor to select a value 4) Apply patch 5) Open cataloguing editor and use 135 field tag editor to select a value, after patch you have more options to select Signed-off-by: George Veranis <gveranis@dataly.gr>
Created attachment 125323 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a This patch add more values to selection of 135a in UNIMARC Test Plan: 1) Add on default framework the field 135a and check the Editor option 2) Set on plugin section the value of unimarc_field_135a.pl 3) Open cataloguing editor and use 135 field tag editor to select a value 4) Apply patch 5) Open cataloguing editor and use 135 field tag editor to select a value, after patch you have more options to select Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Why in French?
(In reply to Jonathan Druart from comment #6) > Why in French? Oops!
Created attachment 125987 [details] [review] Bug 28075: (follow-up) adding all choices and values of 135a Extend patch of 135a to cover all choices with all possible values as described by IFLA for 135a.
Patch no longer applies 8-(... Applying: Bug 28075: Add missing UNIMARC coded data 135a Applying: Bug 28075: (follow-up) adding all choices and values of 135a .git/rebase-apply/patch:15: trailing whitespace. <select name="f1" id="f1"> .git/rebase-apply/patch:117: trailing whitespace. <select name="f2" id="f2"> .git/rebase-apply/patch:193: trailing whitespace. <select name="f3" id="f3"> .git/rebase-apply/patch:239: trailing whitespace. <select name="f4" id="f4"> .git/rebase-apply/patch:295: trailing whitespace. <select name="f5" id="f5"> error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_135a.tt). error: could not build fake ancestor Patch failed at 0001 Bug 28075: (follow-up) adding all choices and values of 135a
Now only one character --- All data in $a is identified by character position within the subfield. Conventionally the character positions are numbered 0-12. Not repeatable. Table of Subfield $a Fixed-length Data Elements Name of Data Element | Number of Characters | Character Positions Type of electronic resource 1 0 Special material designation 1 1 Colour 1 2 Dimensions 1 3 Sound 1 4 Image bit depth 3 5-7 Number of file formats 1 8 Quality assurance target(s) 1 9 Antecedent/Source 1 10 Level of compression 1 11 Reformatting quality 1 12 --- https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf See also https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u_b_135a_1_update2019_onlne_final.pdf https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_135_update2017.pdf
Created attachment 174236 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a This patch add more values to selection of 135a in UNIMARC Test Plan: 1) Add on default framework the field 135a and check the Editor option 2) Set on plugin section the value of unimarc_field_135a.pl 3) Open cataloguing editor and use 135 field tag editor to select a value 4) Apply patch 5) Open cataloguing editor and use 135 field tag editor to select a value, after patch you have more options to select
Created attachment 174237 [details] [review] Bug 28075: (follow-up) adding all choices and values of 135a Extend patch of 135a to cover all choices with all possible values as described by IFLA for 135a.
Rebased on main today, did not apply because the code had been tidied. Therefore there is no cosmetics anymore in the patch. Idk if this needs signoff again
Created attachment 174295 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a This patch add more values to selection of 135a in UNIMARC Test Plan: 1) Add on default framework the field 135a and check the Editor option 2) Set on plugin section the value of unimarc_field_135a.pl 3) Open cataloguing editor and use 135 field tag editor to select a value 4) Apply patch 5) Open cataloguing editor and use 135 field tag editor to select a value, after patch you have more options to select Signed-off-by: David Nind <david@davidnind.com>
Created attachment 174296 [details] [review] Bug 28075: (follow-up) adding all choices and values of 135a Extend patch of 135a to cover all choices with all possible values as described by IFLA for 135a. Signed-off-by: David Nind <david@davidnind.com>
[% IF ( f1d ) %] <option value="d" selected="selected">text</option> [% ELSE %] <option value="d">text</option> [% END %] [% IF ( f1d ) %] <option value="d" selected="selected">text</option> [% ELSE %] <option value="d">text</option> [% END %] Hmm. That looks a bit redundant :)
Created attachment 174552 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a This patch add more values to selection of 135a in UNIMARC Test Plan: 1) Add on default framework the field 135a and check the Editor option 2) Set on plugin section the value of unimarc_field_135a.pl 3) Open cataloguing editor and use 135 field tag editor to select a value 4) Apply patch 5) Open cataloguing editor and use 135 field tag editor to select a value, after patch you have more options to select Signed-off-by: David Nind <david@davidnind.com>
Created attachment 174553 [details] [review] Bug 28075: (follow-up) adding all choices and values of 135a Extend patch of 135a to cover all choices with all possible values as described by IFLA for 135a. Signed-off-by: David Nind <david@davidnind.com>
> Hmm. That looks a bit redundant :) Hum... might be, yes. I removed it just in case O:)
Back to SO
Created attachment 174555 [details] [review] Bug 28075: Add missing UNIMARC coded data 135a This patch add more values to selection of 135a in UNIMARC Test Plan: 1) Add on default framework the field 135a and check the Editor option 2) Set on plugin section the value of unimarc_field_135a.pl 3) Open cataloguing editor and use 135 field tag editor to select a value 4) Apply patch 5) Open cataloguing editor and use 135 field tag editor to select a value, after patch you have more options to select Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 174556 [details] [review] Bug 28075: (follow-up) adding all choices and values of 135a Extend patch of 135a to cover all choices with all possible values as described by IFLA for 135a. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Note for RM: Feels a bit like enhancement to me.
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11