Bug 28075 - Add missing UNIMARC value for coded data 135a
Summary: Add missing UNIMARC value for coded data 135a
Status: Pushed to oldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-02 09:46 UTC by Didier Gautheron
Modified: 2024-12-18 13:44 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the UNIMARC 135$a subfield to add missing values.
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:


Attachments
Bug 28075: Add missing UNIMARC coded data 135a (5.82 KB, patch)
2021-04-02 10:50 UTC, Didier Gautheron
Details | Diff | Splinter Review
Bug 28075: Add missing UNIMARC coded data 135a (5.78 KB, patch)
2021-04-28 21:28 UTC, Didier Gautheron
Details | Diff | Splinter Review
Bug 28075: Add missing UNIMARC coded data 135a (6.09 KB, patch)
2021-09-03 14:29 UTC, George Veranis
Details | Diff | Splinter Review
Bug 28075: Add missing UNIMARC coded data 135a (6.11 KB, patch)
2021-09-03 14:31 UTC, George Veranis
Details | Diff | Splinter Review
Bug 28075: Add missing UNIMARC coded data 135a (6.17 KB, patch)
2021-09-26 12:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 28075: (follow-up) adding all choices and values of 135a (21.13 KB, patch)
2021-10-08 21:37 UTC, George Veranis
Details | Diff | Splinter Review
Bug 28075: Add missing UNIMARC coded data 135a (3.53 KB, patch)
2024-11-07 13:57 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 28075: (follow-up) adding all choices and values of 135a (23.21 KB, patch)
2024-11-07 13:57 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 28075: Add missing UNIMARC coded data 135a (3.58 KB, patch)
2024-11-08 19:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 28075: (follow-up) adding all choices and values of 135a (23.26 KB, patch)
2024-11-08 19:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 28075: Add missing UNIMARC coded data 135a (3.31 KB, patch)
2024-11-15 09:50 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 28075: (follow-up) adding all choices and values of 135a (23.26 KB, patch)
2024-11-15 09:50 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 28075: Add missing UNIMARC coded data 135a (3.41 KB, patch)
2024-11-15 10:09 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 28075: (follow-up) adding all choices and values of 135a (23.36 KB, patch)
2024-11-15 10:10 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Gautheron 2021-04-02 09:46:19 UTC
Value are missing in unimarc_field_135a.tt

cf:
https://www.transition-bibliographique.fr/wp-content/uploads/2018/07/B135-6-2010.pdf
Comment 1 Didier Gautheron 2021-04-02 10:50:15 UTC
Created attachment 119117 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

To test:
    1) Apply patch to an UNIMARC system
    2) Add a notice
    3) Use 135 field tag editor
    4) plugin is working with new value
Comment 2 Didier Gautheron 2021-04-28 21:28:04 UTC
Created attachment 120293 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

To test:
    1) Apply patch to an UNIMARC system
    2) Add a notice
    3) Use 135 field tag editor
    4) plugin is working with new value
Comment 3 George Veranis 2021-09-03 14:29:34 UTC
Created attachment 124464 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: George Veranis <gveranis@dataly.gr>
Comment 4 George Veranis 2021-09-03 14:31:04 UTC
Created attachment 124465 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of unimarc_field_135a.pl
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: George Veranis <gveranis@dataly.gr>
Comment 5 Katrin Fischer 2021-09-26 12:40:08 UTC
Created attachment 125323 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of unimarc_field_135a.pl
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: George Veranis <gveranis@dataly.gr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Jonathan Druart 2021-09-28 12:50:36 UTC
Why in French?
Comment 7 Katrin Fischer 2021-09-28 20:20:39 UTC
(In reply to Jonathan Druart from comment #6)
> Why in French?

Oops!
Comment 8 George Veranis 2021-10-08 21:37:17 UTC
Created attachment 125987 [details] [review]
Bug 28075: (follow-up) adding all choices and values of 135a

Extend patch of 135a to cover all choices with all possible values as
described by IFLA for 135a.
Comment 9 David Nind 2021-10-31 08:45:42 UTC
Patch no longer applies 8-(...

Applying: Bug 28075: Add missing UNIMARC coded data 135a
Applying: Bug 28075: (follow-up) adding all choices and values of 135a
.git/rebase-apply/patch:15: trailing whitespace.
            <select name="f1" id="f1"> 
.git/rebase-apply/patch:117: trailing whitespace.
            <select name="f2" id="f2"> 
.git/rebase-apply/patch:193: trailing whitespace.
            <select name="f3" id="f3"> 
.git/rebase-apply/patch:239: trailing whitespace.
            <select name="f4" id="f4"> 
.git/rebase-apply/patch:295: trailing whitespace.
            <select name="f5" id="f5"> 
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_135a.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 28075: (follow-up) adding all choices and values of 135a
Comment 10 Igor A. Sychev 2022-04-14 16:04:17 UTC
Now only one character
---
All data in $a is identified by character position within the subfield. Conventionally the character positions are numbered 0-12. Not repeatable.

Table of Subfield $a Fixed-length Data Elements
Name of Data Element | Number of Characters | Character Positions
Type of electronic resource 1 0
Special material designation 1 1
Colour 1 2
Dimensions 1 3
Sound 1 4
Image bit depth 3 5-7
Number of file formats 1 8
Quality assurance target(s) 1 9
Antecedent/Source 1 10
Level of compression 1 11
Reformatting quality 1 12
---

https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf
See also
https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u_b_135a_1_update2019_onlne_final.pdf
https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/b_135_update2017.pdf
Comment 11 Baptiste Wojtkowski (bwoj) 2024-11-07 13:57:23 UTC
Created attachment 174236 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of unimarc_field_135a.pl
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select
Comment 12 Baptiste Wojtkowski (bwoj) 2024-11-07 13:57:26 UTC
Created attachment 174237 [details] [review]
Bug 28075: (follow-up) adding all choices and values of 135a

Extend patch of 135a to cover all choices with all possible values as
described by IFLA for 135a.
Comment 13 Baptiste Wojtkowski (bwoj) 2024-11-07 13:59:28 UTC
Rebased on main today, did not apply because the code had been tidied. Therefore there is no cosmetics anymore in the patch.

Idk if this needs signoff again
Comment 14 David Nind 2024-11-08 19:42:01 UTC
Created attachment 174295 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of unimarc_field_135a.pl
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: David Nind <david@davidnind.com>
Comment 15 David Nind 2024-11-08 19:42:04 UTC
Created attachment 174296 [details] [review]
Bug 28075: (follow-up) adding all choices and values of 135a

Extend patch of 135a to cover all choices with all possible values as
described by IFLA for 135a.

Signed-off-by: David Nind <david@davidnind.com>
Comment 16 Marcel de Rooy 2024-11-15 08:14:26 UTC
                            [% IF ( f1d ) %]
                                <option value="d" selected="selected">text</option>
                            [% ELSE %]
                                <option value="d">text</option>
                            [% END %]
                            [% IF ( f1d ) %]
                                <option value="d" selected="selected">text</option>
                            [% ELSE %]
                                <option value="d">text</option>
                            [% END %]

Hmm. That looks a bit redundant :)
Comment 17 Baptiste Wojtkowski (bwoj) 2024-11-15 09:50:26 UTC
Created attachment 174552 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of unimarc_field_135a.pl
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: David Nind <david@davidnind.com>
Comment 18 Baptiste Wojtkowski (bwoj) 2024-11-15 09:50:29 UTC
Created attachment 174553 [details] [review]
Bug 28075: (follow-up) adding all choices and values of 135a

Extend patch of 135a to cover all choices with all possible values as
described by IFLA for 135a.

Signed-off-by: David Nind <david@davidnind.com>
Comment 19 Baptiste Wojtkowski (bwoj) 2024-11-15 09:54:07 UTC
> Hmm. That looks a bit redundant :)

Hum... might be, yes. I removed it just in case O:)
Comment 20 Marcel de Rooy 2024-11-15 10:09:29 UTC
Back to SO
Comment 21 Marcel de Rooy 2024-11-15 10:09:57 UTC
Created attachment 174555 [details] [review]
Bug 28075: Add missing UNIMARC coded data 135a

This patch add more values to selection of 135a in UNIMARC

Test Plan:
    1) Add on default framework the field 135a and check the Editor option
    2) Set on plugin section the value of unimarc_field_135a.pl
    3) Open cataloguing editor and use 135 field tag editor to select a value
    4) Apply patch
    5) Open cataloguing editor and use 135 field tag editor to select a value,
       after patch you have more options to select

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 22 Marcel de Rooy 2024-11-15 10:10:00 UTC
Created attachment 174556 [details] [review]
Bug 28075: (follow-up) adding all choices and values of 135a

Extend patch of 135a to cover all choices with all possible values as
described by IFLA for 135a.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 23 Marcel de Rooy 2024-11-15 10:10:24 UTC
Note for RM: Feels a bit like enhancement to me.
Comment 24 Katrin Fischer 2024-11-19 15:36:37 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 25 Lucas Gass (lukeg) 2024-12-05 23:11:10 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 26 Fridolin Somers 2024-12-18 13:44:46 UTC
Pushed to 23.11.x for 23.11.11