$ /usr/sbin/koha-sitemap --generate instance generates file /var/lib/koha/instance/sitemap/sitemapindex.xml without the EOL of the last line. XML parsers can complain, e.g.: $ xmllint --format /var/lib/koha/instance/sitemap/sitemapindex.xml /var/lib/koha/instance/sitemap/sitemapindex.xml:22: parser error : expected '>' </sitemapindex> ^ /var/lib/koha/instance/sitemap/sitemapindex.xml:22: parser error : Premature end of data in tag sitemapindex line 3 </sitemapindex> ^
I don't recreate the problem. Can you provide more detail please? $ perl debian/scripts/koha-sitemap --enable kohadev Sitemap enabled for kohadev $ perl debian/scripts/koha-sitemap --generate kohadev Sitemap directory for kohadev doesn't exist. Creating. $ xmllint --format /var/lib/koha/kohadev/sitemap/sitemapindex.xml <?xml version="1.0" encoding="UTF-8"?> <sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"> <sitemap> <loc>http://kohadev.myDNSname.org:8080/sitemap0001.xml</loc> <lastmod>2021-04-09</lastmod> </sitemap> </sitemapindex>
(tested on master)
Sorry: don't use xmllint to test it. Use vi instead: a [noeol] message is shown at the bottom of the screen. Anyway, this is a less than minor bug. Please, feel free to move it to trivial or even to delete it.
I can see the [noeol] note in vim, but no error in xmllint. After looking into it a bit, it doesn't seem to have any negative effect.