Bug 27673 lowered the required version of YAML::XS from 0.71 to 0.41, but we use $YAML::XS::Boolean which has been introduced in 0.67. https://metacpan.org/pod/distribution/YAML-LibYAML/lib/YAML/XS.pod#$YAML::XS::Boolean-(since-v0.67) Having an older version results in errors while saving ES mappings: An error occurred when updating Elasticsearch index mappings: Unable to update mappings for index "koha_elastic5_biblios". Reason was: "Could not convert [isbn__sort.index] to boolean". Index needs to be recreated and reindexed.
Created attachment 119307 [details] [review] Bug 28110: Require YAML::XS 0.67 $YAML::XS::Boolean, which is used in Koha::SearchEngine::Elasticsearch, was introduced in 0.67
This was done for U16 support. Mason, can you have a look at this patch please?
Created attachment 119323 [details] [review] Bug 28110: Require YAML::XS 0.67 $YAML::XS::Boolean, which is used in Koha::SearchEngine::Elasticsearch, was introduced in 0.67 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Thanks Julian for the patch ! I had a similar error since a few days when I tried to reindex with ES : Unable to update mappings for index "koha_robin_biblios".Reason was: "Could not convert [koha-auth-number.ignore_malformed] to boolean".Index needs to be recreated and reindexed After I updated the lib lib YAML::XS (sudo cpanm install YAML::XS), and install the patch, reindexation finally worked ! I hope not to interfere Jonathan...
(In reply to Jonathan Druart from comment #2) > This was done for U16 support. > > Mason, can you have a look at this patch please? hi Jonathan, this looks ok to me i have built a new yaml 0.82 package for U16, from cpan root@u16:~# apt-cache policy libyaml-libyaml-perl libyaml-libyaml-perl: Installed: (none) Candidate: 0.82-1+koha2 Version table: 0.82-1+koha2 500 500 http://debian.koha-community.org/koha stable/xenial amd64 Packages 0.76+repack-1~bpo9+1 500 500 http://debian.koha-community.org/koha stable/main amd64 Packages 0.41-6build1 500 500 http://apt.kohaaloha.com:3142/ftp.nz.debian.org/ubuntu xenial/main amd64 Packages
Created attachment 119549 [details] [review] Bug 28110: Require YAML::XS 0.67 $YAML::XS::Boolean, which is used in Koha::SearchEngine::Elasticsearch, was introduced in 0.67 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 21.05, thanks to everybody involved!
Depends on Bug 27673 not in 20.11.x