We have hardcoded a 0 into the logs in Koha/Account.pm 170 new_amountoutstanding => 0, To recreate: 1 - Find a patron with debits, or charge a debit manually 2 - On the patron's accoutning tab Select 'Make a payment' 3 - Select the line and click 'Pay selected' 4 - Pay less than the full amount owed 5 - Go to Tools->log viewer 6 - Enter the patrons borrowernumber into 'Object' and hit enter 7 - Notice the fines log says 'new_amountoutstanding' => 0
I would question whether we actually need the FinesLog at all now... we record all the details as offsets so the finesLog is redundant at this point.
Nick, Kyle, would you agree to remove FinesLog?
The log appears to have changed quite a bit since: $VAR1 = { 'note' => '', 'itemnumber' => undef, 'credit_type_code' => 'PAYMENT', 'description' => '', 'borrowernumber' => 51, 'amount' => -4, 'amountoutstanding' => -4, 'action' => 'create_PAYMENT', 'branchcode' => 'CPL', 'manager_id' => 51 }; Argueably as my fine was 5.00, the amountoutstanding should probably be 1? I am not sure about removing the fines log. It cannot be accessed as easily from the GUI - maybe we need to think how to make the information more visible/resusable first.