There is code in request.tt: homebranch: "[% To.json( Branches.GetName( itemloo.homebranch ) ) | $raw %]", holdallowed: [% itemloo.holdallowed | html %] which earlier rendered itemloo.holdallowed ony digits for itemloo.holdallowed but now it has string, for example 'from_any_library', so it should be in quotes now. To reproduce the problem: 1. Add circulation rules which allow 1 hold to the itemtype 2. Make 1 hold to patron 3. Make sure AllowHoldPolicyOverride syspref enabled 4. Make hold waiting and click revert button, you should see now JS error I am providing a fix today.
Created attachment 119853 [details] [review] Bug 28169: Add quotes around value in template to render proper JS There is code in request.tt: homebranch: "[% ... %]", holdallowed: [% ... %] There only digits where expected earlier in holdallowed but now it can be string value ('from_any_library' for example), so it should be in quotes. To reproduce the problem: 1. Add circulation rules which allow 1 hold only to the itemtype 2. Make sure AllowHoldPolicyOverride syspref enabled 3. Make 1 hold to patron for any biblio which has a few items available, for example on "reset_all dev db set": /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=1 (this biblio record has 4 items) 4. Start another hold for same patron on any biblio record or the same, and keep browser's JS console open, for example on "reset_all dev db set": /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=1 5. You should see now JS error in browser console: Uncaught ReferenceError: from_any_library is not defined Uncaught ReferenceError: columns_settings_borrowers_table is not defined 6. Apply the patch 7. Repeat the steps 4-5 (reload the page) and now the JS error should be gone
Created attachment 119917 [details] [review] Bug 28169: Add quotes around value in template to render proper JS There is code in request.tt: homebranch: "[% ... %]", holdallowed: [% ... %] There only digits where expected earlier in holdallowed but now it can be string value ('from_any_library' for example), so it should be in quotes. To reproduce the problem: 1. Add circulation rules which allow 1 hold only to the itemtype 2. Make sure AllowHoldPolicyOverride syspref enabled 3. Make 1 hold to patron for any biblio which has a few items available, for example on "reset_all dev db set": /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=1 (this biblio record has 4 items) 4. Start another hold for same patron on any biblio record or the same, and keep browser's JS console open, for example on "reset_all dev db set": /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=1 5. You should see now JS error in browser console: Uncaught ReferenceError: from_any_library is not defined Uncaught ReferenceError: columns_settings_borrowers_table is not defined 6. Apply the patch 7. Repeat the steps 4-5 (reload the page) and now the JS error should be gone Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 120235 [details] [review] Bug 28169: Add quotes around value in template to render proper JS There is code in request.tt: homebranch: "[% ... %]", holdallowed: [% ... %] There only digits where expected earlier in holdallowed but now it can be string value ('from_any_library' for example), so it should be in quotes. To reproduce the problem: 1. Add circulation rules which allow 1 hold only to the itemtype 2. Make sure AllowHoldPolicyOverride syspref enabled 3. Make 1 hold to patron for any biblio which has a few items available, for example on "reset_all dev db set": /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=1 (this biblio record has 4 items) 4. Start another hold for same patron on any biblio record or the same, and keep browser's JS console open, for example on "reset_all dev db set": /cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=1 5. You should see now JS error in browser console: Uncaught ReferenceError: from_any_library is not defined Uncaught ReferenceError: columns_settings_borrowers_table is not defined 6. Apply the patch 7. Repeat the steps 4-5 (reload the page) and now the JS error should be gone Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice catch, Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Depends on Bug 27069 not in 20.11.x