Created attachment 120092 [details] Look of the table with highlighted row Highlighting is broken at the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table doesn't get highlighted with the yellow color when you try to edit it, meanwhile every even row does get highlighted as supposed to. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color.
Created attachment 121242 [details] [review] Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color.
Created attachment 121333 [details] [review] Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color.
Created attachment 121334 [details] [review] Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
A really odd bug - I can confirm it is fixed by the patch, but laving as NSO as I have asked Owen if he could take a look at the CSS.
Created attachment 121335 [details] [review] Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 121336 [details] [review] Bug 28204: Fix table highlighting Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 121626 [details] [review] Bug 28204: Fix table highlighting on the items table Fix table highlighting at /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX Every odd row of the table didn't get highlighted with the yellow color when you tried to edit it previously, this patch fixes that. That happened because every odd row had different coloring style that was overwriting yellow highlight. How to reproduce: 1) Head over to the /cgi-bin/koha/cataloguing/additem.pl?biblionumber=XXXX, where XXXX is id of some bilbio record that has more than one biblio item. 2) Press the "Action" button of the first (or any other odd numbered) biblion item, and from the dropdown menu select "edit" option. 3) Notice that it doesn't highlight it with yellow color. 4) Now do the same but with second biblio item (or any even numbered item). 5) Notice that it highlights it with the yellow color. 6) Apply the patch. Do yarn build to compile css. 7) Make sure that every row of the table that you edit gets properly highlighted with the yellow color. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended commit title
Pushed to master for 21.05, thanks to everybody involved!
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.01
> 3) Notice that it doesn't highlight it with yellow color. Without patch, problem seems not to affect 20.11.x