To Test: 1) Set HoldsAutoFill 2) double check hold rules are on next available item. 3) At midway check out barcode 39999000010831 to 23529000035676 patron ( Henry Acevedo) 4) hold next available to Ronnie Ballard (23529000139858) 5) check in 39999000010831, item is in waiting hold state 6) At Centerville check in 39999000010831 --> internal server error Regression introduce by Bug 21944 'Improve efficiency of code' patch, item number is lost in reserve table. Root cause for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 ?
Created attachment 120295 [details] [review] Bug 28259: (bug 21944 follow-up) if a waiting hold is reverted recheck reserve To test: 1) Set HoldsAutoFill 2) double check hold rules are on next available item. 3) At midway check out barcode 39999000010831 to 23529000035676 patron ( Henry Acevedo) 4) hold next available to Ronnie Ballard (23529000139858) 5) check in 39999000010831, item is in waiting hold state 6) At Centerville check in 39999000010831 --> internal server error 7) Reset database 8) Redo 1) to 5) 9) At Centerville check in 39999000010831, item is in transfert with a hold
We just tried to fix this in Bug 25969
But I can confirm this behavior on master. "Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1595. at /kohadevbox/koha/C4/Reserves.pm line 1594"
Created attachment 120347 [details] [review] Bug 28259: (bug 21944 follow-up) if a waiting hold is reverted recheck reserve To test: 1) Set HoldsAutoFill 2) double check hold rules are on next available item. 3) At midway check out barcode 39999000010831 to 23529000035676 patron ( Henry Acevedo) 4) hold next available to Ronnie Ballard (23529000139858) 5) check in 39999000010831, item is in waiting hold state 6) At Centerville check in 39999000010831 --> internal server error 7) Reset database 8) Redo 1) to 5) 9) At Centerville check in 39999000010831, item is in transfert with a hold Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works :)
We need a test for this change.
We really could need this fix. :)
I can no longer reproduce this issue with the test plan in master. Could there have been a fix for this as a side effect of another patch? Anneli, which version are you seeing the problem with?
Katrin, we are using version 21.11.
I tested this now in Bywater's Sandbox and had the same results as Katrin.
I am updating the version here to 21.11 for now.
Still valid ?