Bug 28396 - Call number browse pagination
Summary: Call number browse pagination
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal with 20 votes (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-19 21:33 UTC by Donna
Modified: 2023-11-01 11:20 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28396: Add dataTable to cn_browser (3.38 KB, patch)
2022-09-28 18:10 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 28396: Add dataTable to cn_browser (3.43 KB, patch)
2022-09-30 14:29 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Donna 2021-05-19 21:33:05 UTC
Currently the call number search/browser only shows one page of results. 
/cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl

To see results before or after the results displayed, you need to re-key another search. It would be very useful to either show more results, or provide the option to page forward/back.
Comment 1 Lucas Gass 2022-09-28 18:02:06 UTC
This still seems to be a problem. If you have a lot of the same call numbers you'll be unable to search and find all of them.

I think we could remove the limit on the SQL query, return all the results, and paginate the table with dataTables.
Comment 2 Lucas Gass 2022-09-28 18:10:36 UTC
Created attachment 141065 [details] [review]
Bug 28396: Add dataTable to cn_browser

To test:
1. Have a bunch of similar or exactly the same call numbers. I updated all mine to '123abc'.
2. Set up the cn_browser.pl plugin for some frameworks, I am usiong the default one.
3. Go to '/cgi-bin/koha/cataloguing/plugin_launcher.pl?q=123abc&plugin_name=cn_browser.pl' and search for the call number '123abc'.
4. You will see 15 results and have no way of seeing any more.
5. Apply patch, restart_all
6. Perform the search again. You should see all your results in a paginated dataTable.
Comment 3 ByWater Sandboxes 2022-09-30 14:29:04 UTC
Created attachment 141169 [details] [review]
Bug 28396: Add dataTable to cn_browser

To test:
1. Have a bunch of similar or exactly the same call numbers. I updated all mine to '123abc'.
2. Set up the cn_browser.pl plugin for some frameworks, I am usiong the default one.
3. Go to '/cgi-bin/koha/cataloguing/plugin_launcher.pl?q=123abc&plugin_name=cn_browser.pl' and search for the call number '123abc'.
4. You will see 15 results and have no way of seeing any more.
5. Apply patch, restart_all
6. Perform the search again. You should see all your results in a paginated dataTable.

Signed-off-by: Donna <donna@bywatersolutions.com>
Comment 4 Donna 2022-09-30 14:30:06 UTC
Works as expected, helpful addition!!!
Comment 5 Katrin Fischer 2022-10-22 11:14:52 UTC
Something is not quite right here for me.

As we have no callnumbers in the sample data, I copied the itemnumber into itemcallnumber, set cn_source to z (generic) and ran touch_all_items so set cn_sort.

For me the main purpose of the callnumber browser is to quickly determine if a callnumber has already been used. If it's used, you have a red line, if it's free, you see a green line where the callnumber would be.


1) Existing: Search for 26

Old: You get the red markup for 26. 26 shows between 259 and 260 as expected.

New: Same. OK.

2) Not existing: Search for 1000

Old: Green line between 100 and 101 as expected.

New: You see the green line on top of the table, before 1, you are no longer seeing the "before and after" correctly. Not OK.

3) Existing, not on first page: Search for 500

Old: You get the red markup for 500. 500 shows between 50 and 501 as expected.

New: You see the page with the first numbers, no clue red or green as the number is on a much later page.

You can page there... (not nice) or you can use the table search - more clicks and you don't see the before and after.

Not OK.


2) Modal

For me the window is a bit too small now and the table doesn't resize properly when the window size is increased (maybe side effects of the new staff design?)

3) Sorting

cn_sort should be used for sorting on  the call number column.
Comment 6 Katrin Fischer 2022-10-22 11:15:32 UTC
My numbering is off... should have been 1 abc.
Comment 7 Lucas Gass 2022-11-03 17:56:25 UTC
Perhaps making this into a dataTable is not a good idea. Maybe instead we can either up the number of results shown at a time. Or maybe a system preference so the number of results can be defined there?