Bug 28414 - Fix labels for return claims routes
Summary: Fix labels for return claims routes
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-21 12:00 UTC by Tomás Cohen Arazi
Modified: 2021-05-25 12:48 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Text to go in the release notes:
Version(s) released in:
21.05.00


Attachments
Bug 28414: Fix labels for return claims (2.16 KB, patch)
2021-05-21 12:57 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 28414: Fix labels for return claims (2.22 KB, patch)
2021-05-21 14:05 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2021-05-21 12:00:34 UTC
They display incorrectly in https://api.koha-community.org. They should all be grouped under 'Return claims'. Right they show as 'Returned', 'Return', 'Deleted'.
Comment 1 Tomás Cohen Arazi 2021-05-21 12:57:02 UTC
Created attachment 121277 [details] [review]
Bug 28414: Fix labels for return claims

The way labels are used with RedDoc, we need to tidy them better. We
should do it with all the routes, but this one is specially noisy on the
UI.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Martin Renvoize 2021-05-21 14:05:38 UTC
Created attachment 121278 [details] [review]
Bug 28414: Fix labels for return claims

The way labels are used with RedDoc, we need to tidy them better. We
should do it with all the routes, but this one is specially noisy on the
UI.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2021-05-21 14:06:03 UTC
Solid improvement, going straight for QA
Comment 4 Jonathan Druart 2021-05-25 07:46:31 UTC
Pushed to master for 21.05, thanks to everybody involved!