I feel like I'm missing something obvious, because it can't be that a whole page is not translatable... To go to this page: 1) Go to Acquisitions 2) Search for a vendor 3) Create a basket 4) Add to basket "from a new file" 5) Stage a marc file 6) Click on Add staged files to basket You should be on the addorderiso2709 page. I did ./translate update fr-CA, then using the git grep command, I searched for the string "Add orders from" which is the title of the page, and I can't find it anywhere in the po files. The string only comes out in the tt file and in the release notes files...
Hi Caroline, which version did you test this on?
Caroline, I am not sure how this can even be possible... but I am seeing the exact same thing for de-DE in our package based installation of 20.11.05
Example URL: /cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=6&basketno=25&booksellerid=8
Try `gulp po:update` to update the po files.
Hum, forget that. There is something wrong, indeed.
Created attachment 121373 [details] [review] Bug 28419: Fix addorderiso2709.tt translatability It seems that the html tag within the TT comment breaks the translate script
It seems that this patch fixes the problem. Can you confirm please?
Created attachment 121374 [details] [review] Bug 28419: Remove suspicious occurrence in opac-shelves.tt
This is the only other occurrence I found. I don't have time right now to fix the translate script, and it does not seem a good idea to modify it few days before the release anyway :)
Created attachment 121376 [details] [review] Bug 28419: Remove suspicious occurrence in opac-shelves.tt
Created attachment 121394 [details] [review] Bug 28419: Fix addorderiso2709.tt translatability It seems that the html tag within the TT comment breaks the translate script
Created attachment 121395 [details] [review] Bug 28419: Remove suspicious occurrence in opac-shelves.tt
Created attachment 121413 [details] [review] Bug 28419: Fix addorderiso2709.tt translatability It seems that the html tag within the TT comment breaks the translate script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 121414 [details] [review] Bug 28419: Remove suspicious occurrence in opac-shelves.tt Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Well sleuthed.. works as expected and passes QA scripts.. I couldn't find any other cases with a grep/ack. Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Thanks everyone! Just for information, I noticed this on a client's 20.05 installation. So if it's backportable, it would be useful. :) Sorry I couldn't help more on this I'm swamped with client work atm.
Pushed to 20.11.x for 20.11.07
Backported: Pushed to 20.05.x branch for 20.05.13
Backported to 19.11.x for 19.11.19