Created attachment 121396 [details] [review] Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled
Created attachment 121481 [details] [review] Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Test plan I followed: 1 - turn on TrackLastPatronActivity 2 - find a patron, look at their lastseen date 3 - check out to them, confirm lastseen didn't change 4 - apply patch, restart stuff 5 - repeat 3, but lastseen did change this time!
Hi Nick, please also update the preference description. I am adding a dependency on the recent rephrase that will probably be backported/pushed first to avoid additional confusion.
Created attachment 121609 [details] [review] Bug 28455: Update wording on TrackLastPatronActivity This patch updates the wording on TrackLackPatronActivity to maintain the corrections from bug 28467 and also reflect the change made in this bug. It should now read: The first time each day that a patron either logs into the OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will update with the current date and time.
I added a patch to update the syspref and set this back to Needs Signoff. Thanks!
Created attachment 121617 [details] [review] Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 121618 [details] [review] Bug 28455: Update wording on TrackLastPatronActivity This patch updates the wording on TrackLackPatronActivity to maintain the corrections from bug 28467 and also reflect the change made in this bug. It should now read: The first time each day that a patron either logs into the OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will update with the current date and time. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 122482 [details] [review] Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Created attachment 122483 [details] [review] Bug 28455: Update wording on TrackLastPatronActivity This patch updates the wording on TrackLackPatronActivity to maintain the corrections from bug 28467 and also reflect the change made in this bug. It should now read: The first time each day that a patron either logs into the OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will update with the current date and time. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Created attachment 122493 [details] [review] Bug 28455: lastseen should be updated at checkout if TrackLastPatronActivity is enabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 122494 [details] [review] Bug 28455: Update wording on TrackLastPatronActivity This patch updates the wording on TrackLackPatronActivity to maintain the corrections from bug 28467 and also reflect the change made in this bug. It should now read: The first time each day that a patron either logs into the OPAC, connects to Koha via SIP, or checks an item out, borrowers.lastseen will update with the current date and time. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, makes sense. Passing QA
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.02
In this case i my opinion we should rename Koha::Patron::track_login into track_activity, same for C4::Auth::track_login_daily.
Pushed to 20.11.x for 20.11.09
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.