This is caused by bug 26533.
Created attachment 121456 [details] [review] Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 121457 [details] [review] Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 121458 [details] [review] Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the staff interface 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
It works :D Fixed the test plan: in the OPAC => in the staff interface
Created attachment 121459 [details] [review] Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Current status: Signed Off
Created attachment 121460 [details] [review] Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
There is another change after this patch. After a "all headings" search, it was going back to "Search main heading ($a only)" without the patch. With the patch, it stays on "all headings". It's the only non-default tab that had this issue. I don't know why this change though.
(In reply to Victor Grousset/tuxayo from comment #7) > There is another change after this patch. After a "all headings" search, it > was going back to "Search main heading ($a only)" without the patch. > With the patch, it stays on "all headings". > It's the only non-default tab that had this issue. > > I don't know why this change though. I think since we were passing an invalid index to search we couldn't match and select the correct tab on return. This behavior is the correct behavior :-)
FYI Victor's SO got lost.
Created attachment 121461 [details] [review] Bug 28475: Fix searching all headings This patch fixes the value of a hidden input that was mistakenly changed and prevents search all headings from working. To test: 1. Open the authorities section in the OPAC 2. Choose the 'Search all headings' tab 3. Search for 'a' => FAIL: No results 4. Empty the search box, and make sure 'Search all headings' is selected => SUCCESS: There are authority records 5. Apply this patch 6. Reload the page 7. Retry 3 and 4 => SUCCESS: Searching is back! 8. Sign off :-D Sponsored-by: Asociación Latinoamericana de Integración Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(In reply to Nick Clemens from comment #8) > I think since we were passing an invalid index to search we couldn't match > and select the correct tab on return. This behavior is the correct behavior > :-) Great, thanks :D
Does Bug 26533 still work after this change?
It quickly tested that exact match work but it turns out I didn't new the subtleties. See bug 26533 comment 18
Pushed to master for 21.05, thanks to everybody involved!
Test plan has a mistake : 1. Open the authorities section in the OPAC => It in is in staff interface
Pushed to 20.11.x for 20.11.07
(In reply to Fridolin Somers from comment #15) > Test plan has a mistake : > > 1. Open the authorities section in the OPAC > => It in is in staff interface Oops.
Ready to backport to the new oldoldstable (20.05.x). Applied locally until getting the push rights.
Backported: Pushed to 20.05.x branch for 20.05.13
Not backported to 19.11.x Couldn't reproduce the bug