Bug 28528 - bulkmarcimport delete option doesn't delete biblio_metadata
Summary: bulkmarcimport delete option doesn't delete biblio_metadata
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major
Assignee: Roman Dolny
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-08 11:08 UTC by Katrin Fischer
Modified: 2025-04-11 08:50 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 28528: bulkmarcimport delete option doesn't delete biblio_metadata (2.18 KB, patch)
2025-01-20 20:36 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 28528: bulkmarcimport delete option doesn't delete biblio_metadata (2.24 KB, patch)
2025-04-03 21:29 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2021-06-08 11:08:54 UTC
When using bulkmarcimport with the -d switch should not only delete biblio, biblioitems and items, but also biblio_metadata.

I haven't checked if a FK takes care of the data, but if it does, we should still also reset the AUTO_INCREMENT:

https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/migration_tools/bulkmarcimport.pl#L172
Comment 1 Roman Dolny 2025-01-20 20:36:53 UTC
Created attachment 176844 [details] [review]
Bug 28528: bulkmarcimport delete option doesn't delete biblio_metadata

When using bulkmarcimport with the -d switch should not only delete
biblio, biblioitems and items, but also biblio_metadata.

I haven't checked if a FK takes care of the data, but if it does,
we should still also reset the AUTO_INCREMENT:...

Test plan:
==========
1. Check (and notice) the number of records in the biblio (bCount) and
   biblio_metadata (bmCount) tables. Check the AUTO_INCREMENT value
   for these tables (bAI, bmAI).
2. Import bibliographic records with delete, turn off foreign key checks
   and non-existent filename:
   misc/migration_tools/bulkmarcimport.pl -b -d -fk -file=non-exist-file
==> "Could not open..." is OK, file doesn't exist.
3. Repeat p. 1 and compare with previously noticed:
   bCount => 0 (OK)
   bmCount => unchanged (NOT OK)
   bAI => 1 (OK)
   bmAI => unchanged (NOT OK)
4. Apply the patch.
5. Repeat p. 2-3:
   bCount => 0 (OK)
   bmCount => 0 (changed, OK)
   bAI => 1 (OK)
   bmAI => 1 (changed, OK)

Sponsored-by: Ignatianum University in Cracow
Comment 2 Janusz Kaczmarek 2025-04-03 21:29:24 UTC
Created attachment 180606 [details] [review]
Bug 28528: bulkmarcimport delete option doesn't delete biblio_metadata

When using bulkmarcimport with the -d switch should not only delete
biblio, biblioitems and items, but also biblio_metadata.

I haven't checked if a FK takes care of the data, but if it does,
we should still also reset the AUTO_INCREMENT:...

Test plan:
==========
1. Check (and notice) the number of records in the biblio (bCount) and
   biblio_metadata (bmCount) tables. Check the AUTO_INCREMENT value
   for these tables (bAI, bmAI).
2. Import bibliographic records with delete, turn off foreign key checks
   and non-existent filename:
   misc/migration_tools/bulkmarcimport.pl -b -d -fk -file=non-exist-file
==> "Could not open..." is OK, file doesn't exist.
3. Repeat p. 1 and compare with previously noticed:
   bCount => 0 (OK)
   bmCount => unchanged (NOT OK)
   bAI => 1 (OK)
   bmAI => unchanged (NOT OK)
4. Apply the patch.
5. Repeat p. 2-3:
   bCount => 0 (OK)
   bmCount => 0 (changed, OK)
   bAI => 1 (OK)
   bmAI => 1 (changed, OK)

Sponsored-by: Ignatianum University in Cracow
Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Comment 3 Janusz Kaczmarek 2025-04-03 21:32:18 UTC
NB, without this patch after performing bulkmarcimport.pl -d -fk old content of biblio_metadata remains in the table!
Comment 4 Marcel de Rooy 2025-04-11 08:48:20 UTC
(In reply to Janusz Kaczmarek from comment #3)
> NB, without this patch after performing bulkmarcimport.pl -d -fk old content
> of biblio_metadata remains in the table!

Yeah, but thats probably the idea behind passing -fk to block the foreign key's cascaded delete.
Comment 5 Marcel de Rooy 2025-04-11 08:49:22 UTC
(In reply to Katrin Fischer from comment #0)
> When using bulkmarcimport with the -d switch should not only delete biblio,
> biblioitems and items, but also biblio_metadata.
> 
> I haven't checked if a FK takes care of the data, but if it does, we should
> still also reset the AUTO_INCREMENT:

Yes, it has a FK with delete.
Comment 6 Marcel de Rooy 2025-04-11 08:50:35 UTC
Moving to In Discussion. If you pass -fk and we are still going to delete, this may be confusing?