OverDrive integration generates HTML in a couple of different places, and I think it could use some improvements. Especially the "OverDrive Account" tab which shows titles checked out to and on hold for a logged-in patron.
Created attachment 121748 [details] [review] Bug 28537: Improve HTML generated by OverDrive integration This patch makes changes to the way HTML is generated when showing output from OverDrive integration: - Buttons have Bootstrap button classes - Layout of information is improved. - Handling of cover image thumbnails is improved, especially in cases where images were much larger than expected. - An OverDrive-specific CSS file is added. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display well, with item thumbnails showing in a column to the left, and item information showing to the right. - Controls should be styled with standard Bootstrap style. - Confirm that operations work correctly: Acessing titles, checking in, canceling holds, etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, especially thumbnails. - Confirm that operations work correctly: Checking out and placing holds.
Created attachment 125000 [details] [review] Bug 28537: Improve HTML generated by OverDrive integration This patch makes changes to the way HTML is generated when showing output from OverDrive integration: - Buttons have Bootstrap button classes - Layout of information is improved. - Handling of cover image thumbnails is improved, especially in cases where images were much larger than expected. - An OverDrive-specific CSS file is added. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display well, with item thumbnails showing in a column to the left, and item information showing to the right. - Controls should be styled with standard Bootstrap style. - Confirm that operations work correctly: Acessing titles, checking in, canceling holds, etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, especially thumbnails. - Confirm that operations work correctly: Checking out and placing holds.
Created attachment 125001 [details] [review] Bug 28537: (follow-up) Correct and improve OverDrive checkout modal This patch corrects the markup of the modal which is displayed when the user clicks the "Download as" button in their list of OverDrive checkouts. The modal markup had not been updated in the conversion to Bootstrap 4. I have also modified the markup generated when listing the download format options so that they use some standard Bootstrap 4 classes, improving the layout a little. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - In the list of current checkouts, click the "Download as" button for one of the titles. - A modal window should display with a list of radio buttons for each available format. - Confirm that the format text acts as the label for the radio button. - Confirm that closing the modal without making a selection works correctly. - Confirm that making a selection and submitting the form closes the modal and submits your choice.
Created attachment 126324 [details] [review] Bug 28537: Improve HTML generated by OverDrive integration This patch makes changes to the way HTML is generated when showing output from OverDrive integration: - Buttons have Bootstrap button classes - Layout of information is improved. - Handling of cover image thumbnails is improved, especially in cases where images were much larger than expected. - An OverDrive-specific CSS file is added. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display well, with item thumbnails showing in a column to the left, and item information showing to the right. - Controls should be styled with standard Bootstrap style. - Confirm that operations work correctly: Acessing titles, checking in, canceling holds, etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, especially thumbnails. - Confirm that operations work correctly: Checking out and placing holds.
Created attachment 126325 [details] [review] Bug 28537: (follow-up) Correct and improve OverDrive checkout modal This patch corrects the markup of the modal which is displayed when the user clicks the "Download as" button in their list of OverDrive checkouts. The modal markup had not been updated in the conversion to Bootstrap 4. I have also modified the markup generated when listing the download format options so that they use some standard Bootstrap 4 classes, improving the layout a little. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - In the list of current checkouts, click the "Download as" button for one of the titles. - A modal window should display with a list of radio buttons for each available format. - Confirm that the format text acts as the label for the radio button. - Confirm that closing the modal without making a selection works correctly. - Confirm that making a selection and submitting the form closes the modal and submits your choice.
*** Bug 29323 has been marked as a duplicate of this bug. ***
Created attachment 126969 [details] [review] Bug 28537: Improve HTML generated by OverDrive integration This patch makes changes to the way HTML is generated when showing output from OverDrive integration: - Buttons have Bootstrap button classes - Layout of information is improved. - Handling of cover image thumbnails is improved, especially in cases where images were much larger than expected. - An OverDrive-specific CSS file is added. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - The contents of the tab should display well, with item thumbnails showing in a column to the left, and item information showing to the right. - Controls should be styled with standard Bootstrap style. - Confirm that operations work correctly: Acessing titles, checking in, canceling holds, etc. - Perform a catalog search which will return results also found in your OverDrive collection. - Open the OverDrive results page. - The page should display correctly, especially thumbnails. - Confirm that operations work correctly: Checking out and placing holds. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 126970 [details] [review] Bug 28537: (follow-up) Correct and improve OverDrive checkout modal This patch corrects the markup of the modal which is displayed when the user clicks the "Download as" button in their list of OverDrive checkouts. The modal markup had not been updated in the conversion to Bootstrap 4. I have also modified the markup generated when listing the download format options so that they use some standard Bootstrap 4 classes, improving the layout a little. To test you must have valid credentials entered in system preferences for the OverDrive API. You should test using a patron who has holds and current checkouts in OverDrive. Apply the patch and log in to the OPAC. - On the "Your summary" page, open the "OverDrive Account" tab. - Log in to your OverDrive account. - In the list of current checkouts, click the "Download as" button for one of the titles. - A modal window should display with a list of radio buttons for each available format. - Confirm that the format text acts as the label for the radio button. - Confirm that closing the modal without making a selection works correctly. - Confirm that making a selection and submitting the form closes the modal and submits your choice. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Small patch, big improvement, moving to PQA
Pushed to master for 21.11, thanks to everybody involved!