Bug 28538 - Regression - Date of birth entered without correct format causes internal server error
Summary: Regression - Date of birth entered without correct format causes internal ser...
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Nick Clemens
QA Contact: Tomás Cohen Arazi
URL:
Keywords:
Depends on: 27937 28351
Blocks:
  Show dependency treegraph
 
Reported: 2021-06-09 17:59 UTC by Nick Clemens
Modified: 2021-06-18 12:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
21.11.00,21.05.01


Attachments
Bug 28538: Insert formatted date if valid (2.47 KB, patch)
2021-06-09 18:03 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 28538: Insert formatted date if valid (2.51 KB, patch)
2021-06-10 13:20 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 28538: Insert formatted date if valid (2.56 KB, patch)
2021-06-11 20:06 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2021-06-09 17:59:20 UTC
Bug 28351 removed the code from Bug 27937 - but it reintroduced the error caused by single date months/days

The issue appears to be that the 'Restrictions' section is in the circulation pages, which adds timepicker, this undoes the dateFormat pref and the date fails to be set after validation.
Comment 1 Nick Clemens 2021-06-09 18:03:01 UTC
Created attachment 121745 [details] [review]
Bug 28538: Insert formatted date if valid

This patch restores the setting of the date from bug 27937 and adds a parsing of the date to
ensure the correct format

To test:
1 - Follow test plan from bug 27937 - it fails
2 - Follow test plan from bug 28351 - it succeeds
3 - Apply patch
4 - Repeat 1-2
5 - both plans pass now
Comment 2 Andrew Fuerste-Henry 2021-06-10 13:20:22 UTC
Created attachment 121784 [details] [review]
Bug 28538: Insert formatted date if valid

This patch restores the setting of the date from bug 27937 and adds a parsing of the date to
ensure the correct format

To test:
1 - Follow test plan from bug 27937 - it fails
2 - Follow test plan from bug 28351 - it succeeds
3 - Apply patch
4 - Repeat 1-2
5 - both plans pass now

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 3 Tomás Cohen Arazi 2021-06-11 20:06:39 UTC
Created attachment 121882 [details] [review]
Bug 28538: Insert formatted date if valid

This patch restores the setting of the date from bug 27937 and adds a parsing of the date to
ensure the correct format

To test:
1 - Follow test plan from bug 27937 - it fails
2 - Follow test plan from bug 28351 - it succeeds
3 - Apply patch
4 - Repeat 1-2
5 - both plans pass now

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2021-06-11 20:07:57 UTC
Both test plans followed and works as expected. i.e. no regressions introduced, and the 'fixed' behaviour is re-introduced. There's an unadvertised input size change, that makes sense :-D

No QA complaints.
Comment 5 Jonathan Druart 2021-06-14 15:34:43 UTC
Pushed to master for 21.11, thanks to everybody involved!
Comment 6 Kyle M Hall 2021-06-18 12:44:01 UTC
Pushed to 21.05.x for 21.05.01