Bug 28577 - Add column for copynumber on overdues report
Summary: Add column for copynumber on overdues report
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-16 19:11 UTC by Marjorie Barry-Vila
Modified: 2022-10-24 23:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
This adds the copynumber as optional column to the circulation report 'overdues'. The column can be made visible temporarily or permanently using the table settings configuration.
Circulation function:


Attachments
Bug 28577: Add column for copynumber to overdues report (4.65 KB, patch)
2022-10-17 22:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Screenshots of column display and settings table (69.22 KB, application/pdf)
2022-10-18 19:44 UTC, David Nind
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marjorie Barry-Vila 2021-06-16 19:11:43 UTC
Hi,

It would be fine to see field copynumber from items on overdue circulation report (/cgi-bin/koha/circ/overdue.pl)

and in columns_settings on circ-overdues

Thanks,

Marjorie
Comment 1 Katrin Fischer 2022-10-17 22:09:53 UTC
Created attachment 142034 [details] [review]
Bug 28577: Add column for copynumber to overdues report

This adds the copynumber as optional column to the circulation report
'overdues'. The column can be made visible temporarily or
permanently using the table settings configuration.

To test:
* Make sure you have some overdue checkouts in your installation.
* Make sure the items for those checkouts have copynumber set,
  also one should have serial enumaration.
* Go to circulation > overdues
* Verify the copynumber column is hidden by default, but can
  be made visible using the column settings
* Verify that the export to CSV via the link on top of the table
 (not the table export) works correctly and includes both:
  copynumber and serial enumeration

Serial enumaration shows after the title in the overdues list,
but was missing from export. This was also fixed here.
Comment 2 David Nind 2022-10-18 19:44:35 UTC
Created attachment 142090 [details]
Screenshots of column display and settings table

Hi Katrin.

After the patch is applied (see attached screenshots):

- Item type is displaying in the copy number column, and copy number is displaying in the item type column.

- There is no column name label in the table settings (and the wrong columns are toggled).

David
Comment 3 Katrin Fischer 2022-10-18 20:02:51 UTC
(In reply to David Nind from comment #2)
> Created attachment 142090 [details]
> Screenshots of column display and settings table
> 
> Hi Katrin.
> 
> After the patch is applied (see attached screenshots):
> 
> - Item type is displaying in the copy number column, and copy number is
> displaying in the item type column.
> 
> - There is no column name label in the table settings (and the wrong columns
> are toggled).
> 
> David

Hm, I wonder what I did there, will have a look.
Comment 4 David Nind 2022-10-24 23:23:51 UTC
In admin/columns_settings.yml columnname is spelt incorrectly - spelt as columname (In reply to Katrin Fischer from comment #3)
> (In reply to David Nind from comment #2)
> > Created attachment 142090 [details]
> > Screenshots of column display and settings table
> > 
> > Hi Katrin.
> > 
> > After the patch is applied (see attached screenshots):
> > 
> > - Item type is displaying in the copy number column, and copy number is
> > displaying in the item type column.
> > 
> > - There is no column name label in the table settings (and the wrong columns
> > are toggled).
> > 
> > David
> 
> Hm, I wonder what I did there, will have a look.

For the column name label not displaying, columnname is spelt incorrectly in admin/columns_settings.yml - spelt as columname. (Spotted by Lucas for bug 21381.)