Bug 28690 - Important and mandatory not checked on all item forms
Summary: Important and mandatory not checked on all item forms
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-08 13:58 UTC by Jonathan Druart
Modified: 2021-10-14 15:18 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28689: Extra %s in alert message when saving an items (1.60 KB, patch)
2021-07-15 13:10 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2021-07-08 13:58:28 UTC
If item subfields has marked as mandatory or important, there is no alert when the item is added from the acquisition or serial modules.

acqui/neworderempty.tt:                var empty_item_mandatory = CheckMandatorySubfields(ff);
acqui/orderreceive.tt:                var total_errors = CheckMandatorySubfields(form);
serials/serials-edit.tt:            total_errors = total_errors + CheckMandatorySubfields(this);
Comment 1 Owen Leonard 2021-07-15 13:10:15 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2021-07-15 13:43:56 UTC Comment hidden (obsolete)
Comment 3 jmbroust 2021-10-14 15:18:46 UTC
Hi Jonathan,
I am testing Koha 20.11.10. In acquisition module i can't reproduce the problem on neworderempty.pl (it works for me) but I can notice this problem in addorderiso2709.pl (cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=777&basketno=9077&booksellerid=131).
When placing orders from a batch (from a staged file as Electre).
Hope it can help.