If item subfields has marked as mandatory or important, there is no alert when the item is added from the acquisition or serial modules. acqui/neworderempty.tt: var empty_item_mandatory = CheckMandatorySubfields(ff); acqui/orderreceive.tt: var total_errors = CheckMandatorySubfields(form); serials/serials-edit.tt: total_errors = total_errors + CheckMandatorySubfields(this);
Created attachment 122859 [details] [review] Bug 28689: Extra %s in alert message when saving an items This patch removes an unnecessary %s in the text built to show when there are errors in the cataloging add item form. To reproduce, open the add item form in cataloging and click "Add item" without filling in all mandatory fields. You should see an alert message that contains, "- %s 1 mandatory fields empty (highlighted)" To test, apply the patch and return to the add item form. Now when you save an incomplete form the message should omit the %s: - 1 mandatory fields empty (highlighted)
(In reply to Owen Leonard from comment #1) > Created attachment 122859 [details] [review] [review] > Bug 28689: Extra %s in alert message when saving an items Sorry, wrong bug!
Hi Jonathan, I am testing Koha 20.11.10. In acquisition module i can't reproduce the problem on neworderempty.pl (it works for me) but I can notice this problem in addorderiso2709.pl (cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=777&basketno=9077&booksellerid=131). When placing orders from a batch (from a staged file as Electre). Hope it can help.