Some news are used for custom text with a specific language, for example "opacheader". The bug is that in these locations, news for all (staff and opac) are displayed. This is because GetNewsToDisplay uses SQL : opac_news.lang = '' OR opac_news.lang = ?
Created attachment 122698 [details] [review] Bug 28698: Fix news for all displays in all locations Some news are used for custom text with a specific language, for example "opacheader". The bug is that in these locations, news for all (staff and opac) are displayed. This is because GetNewsToDisplay uses SQL : opac_news.lang = '' OR opac_news.lang = ? This patch is a quick fix. This feature maybe needs a big revamping. Test plan : 1) Remove any news 2) Create a news with empty 'Display location' and some content 3) Display OPAC interface 4) without patch you see in location of 'opacheader', 'opacnavright' ... the content of the news 5) With patch you see content of the news only in news table 6) Create a news for opacheader 7) Check it appears in correct language
Fridolin, bug 22544 removed C4::NewsChannels, and I think it fixes it. Note that I am about to provide a patch on bug 24387 to clean that area a bit.
(In reply to Jonathan Druart from comment #2) > Fridolin, bug 22544 removed C4::NewsChannels, and I think it fixes it. I confirm. > > Note that I am about to provide a patch on bug 24387 to clean that area a > bit. Ahhh super. So I close.
Don't we need it for 21.05?
(In reply to Jonathan Druart from comment #4) > Don't we need it for 21.05? Yes! I think this can be very useful for 21.05 and below.
I'm only seeing the news item displayed in the normal news location in the OPAC. Do I need another language installed and enabled?
(In reply to David Nind from comment #6) > I'm only seeing the news item displayed in the normal news location in the > OPAC. > > Do I need another language installed and enabled? Did you test on master ? This is only for <= 21.05.x
(In reply to Fridolin Somers from comment #7) > Did you test on master ? > This is only for <= 21.05.x I tested in 21.05. I've retested and I'm seeing the problem now - I had to browse around a few pages, then it appeared in the places it shouldn't (but it didn't initially with the browser cache cleared). Sign-off on the way!
Created attachment 128098 [details] [review] Bug 28698: Fix news for all displays in all locations Some news are used for custom text with a specific language, for example "opacheader". The bug is that in these locations, news for all (staff and opac) are displayed. This is because GetNewsToDisplay uses SQL : opac_news.lang = '' OR opac_news.lang = ? This patch is a quick fix. This feature maybe needs a big revamping. Test plan : 1) Remove any news 2) Create a news with empty 'Display location' and some content 3) Display OPAC interface 4) without patch you see in location of 'opacheader', 'opacnavright' ... the content of the news 5) With patch you see content of the news only in news table 6) Create a news for opacheader 7) Check it appears in correct language Signed-off-by: David Nind <david@davidnind.com>
Created attachment 128678 [details] [review] Bug 28698: Fix news for all displays in all locations Some news are used for custom text with a specific language, for example "opacheader". The bug is that in these locations, news for all (staff and opac) are displayed. This is because GetNewsToDisplay uses SQL : opac_news.lang = '' OR opac_news.lang = ? This patch is a quick fix. This feature maybe needs a big revamping. Test plan : 1) Remove any news 2) Create a news with empty 'Display location' and some content 3) Display OPAC interface 4) without patch you see in location of 'opacheader', 'opacnavright' ... the content of the news 5) With patch you see content of the news only in news table 6) Create a news for opacheader 7) Check it appears in correct language Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to 21.05.x for 21.05.08
This ticket depend on an enhancement from 21.11 But it was backported to 21.05 . Does that mean 20.11 should be affected as well?
Yes, this is only for <= 21.05.x I removed dependency.
I can confirm the bug in 20.11 - we have seen it a few times when updating.
Backported: Pushed to 20.11.x branch for 20.11.14 > 4) without patch you see in location of 'opacheader', 'opacnavright' ... the content of the news Indeed, that's very messy!