The RECEIPT notice was not yet translated in fr-CA. I hope I'm doing this correctly. I admit I'm a bit lost since the change of the translation process for SQL data. Let me know if I need to change something.
Ok, I'm even more lost than I thought! I found the name and title of the letter in translate.koha-community.org. But I can't find the content (e.g. I'm looking for "Operator ID" which is in the RECEIPT). How do I submit a change to get the content of the letter in translate.k-c.org? Or rather, how do we need to change the letter in order for the content to show up in translate.k-c.org?
Hi Caroline, the texts of any sample notice is stored in a .yml file now and the translation should be done via the pootle files. https://git.koha-community.org/Koha-community/Koha/src/branch/master/installer/data/mysql/en/mandatory/sample_notices.yml#L1112 But I didn't find 'Operator ID:' on pootle - and now I am confused too... https://translate.koha-community.org/fr_CA/21.11/translate/#search=Operator%20ID%3A&sfields=source,target&soptions=exact
Created attachment 134768 [details] [review] Bug 28707: Translate RECEIPT notice There is a badly crafted regex used when extracting strings in multiline fields in yaml files The regex is my own, introduced in Bug 24262, sorry. This patch correct it a little. Better eyes are welcome. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing strings egrep "Total out|Operator ID|August 31" po/fr-CA-installer.po first two are from sample notices, third from sample creator data 3) apply the patch, repeat 1) 4) repeat 2), verify the strings are present in the translation file 5) translate some of the new strings, install the language, verify strings are present in the translated files ./translate install fr-CA check fr-CA/optional/sample_creator_data.yml and fr-CA/mandatory/sample_notices.yml There are some 60+ new strings.
I found the problem, please check if this patch fixes it.
Created attachment 137798 [details] [review] Bug 28707: Translate RECEIPT notice There is a badly crafted regex used when extracting strings in multiline fields in yaml files The regex is my own, introduced in Bug 24262, sorry. This patch correct it a little. Better eyes are welcome. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing strings egrep "Total out|Operator ID|August 31" po/fr-CA-installer.po first two are from sample notices, third from sample creator data 3) apply the patch, repeat 1) 4) repeat 2), verify the strings are present in the translation file 5) translate some of the new strings, install the language, verify strings are present in the translated files ./translate install fr-CA check fr-CA/optional/sample_creator_data.yml and fr-CA/mandatory/sample_notices.yml There are some 60+ new strings.
Created attachment 138452 [details] [review] Bug 28707: Translate RECEIPT notice There is a badly crafted regex used when extracting strings in multiline fields in yaml files The regex is my own, introduced in Bug 24262, sorry. This patch correct it a little. Better eyes are welcome. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing strings egrep "Total out|Operator ID|August 31" po/fr-CA-installer.po first two are from sample notices, third from sample creator data 3) apply the patch, repeat 1) 4) repeat 2), verify the strings are present in the translation file 5) translate some of the new strings, install the language, verify strings are present in the translated files ./translate install fr-CA check fr-CA/optional/sample_creator_data.yml and fr-CA/mandatory/sample_notices.yml There are some 60+ new strings. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.06
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.
Thanks! Pushed to 21.11 for 21.11.12