Bug 28712 - Printed slips for fees come up empty if no notice is defined for the user's preferred language
Summary: Printed slips for fees come up empty if no notice is defined for the user's p...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: 21.05
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-14 09:39 UTC by Katrin Fischer
Modified: 2021-07-19 21:36 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2021-07-14 09:39:51 UTC
When printing slips for account actions and using the TanslatedNotices feature, there is no fallback to "default", when there is not notice template for the user's preferred language. See bug 28487 for a similar instance of this.

To test:
- Create a manual fee of any kind
- Pay it
- Click on "print" and confirm the slip comes up with content
- Turn on TranslateNotices system preference
- Repeat "print" action - the slip should still print
- Edit your patron and set a language other than "default"
- Repeat print, the page now comes up empty

I think this is quite hard to understand track down for users to figure out, so while there is a workaround (setting the notices) we should really fix it.
Comment 1 Katrin Fischer 2021-07-14 10:29:20 UTC
Hm, also noticing a behaviour change here: 
When the notices were hardcoded, you could switch the language notice by switching the GUI language. Not it depends on the settings in the patron record.
This means it's no longer possible to print i.e. an English/German slip on request.

I wonder how others see this and if we should file a separate enhancement request to allow choosing the slip language to print?
Comment 2 Jonathan Druart 2021-07-16 09:45:16 UTC
Did you report it for master? Should have been fixed by bug 26734.
Comment 3 Katrin Fischer 2021-07-19 21:36:40 UTC
Should have added we are seeing this in latest 20.11. I believe it's also in 21.05.

Bug 26734 doesn't qualify for backporting (changes to notices), so we might want an easy temp fix here.