When printing slips for account actions and using the TanslatedNotices feature, there is no fallback to "default", when there is not notice template for the user's preferred language. See bug 28487 for a similar instance of this.
- Create a manual fee of any kind
- Pay it
- Click on "print" and confirm the slip comes up with content
- Turn on TranslateNotices system preference
- Repeat "print" action - the slip should still print
- Edit your patron and set a language other than "default"
- Repeat print, the page now comes up empty
I think this is quite hard to understand track down for users to figure out, so while there is a workaround (setting the notices) we should really fix it.
Hm, also noticing a behaviour change here:
When the notices were hardcoded, you could switch the language notice by switching the GUI language. Not it depends on the settings in the patron record.
This means it's no longer possible to print i.e. an English/German slip on request.
I wonder how others see this and if we should file a separate enhancement request to allow choosing the slip language to print?
Did you report it for master? Should have been fixed by bug 26734.
Should have added we are seeing this in latest 20.11. I believe it's also in 21.05.
Bug 26734 doesn't qualify for backporting (changes to notices), so we might want an easy temp fix here.
OK.. I did some digging.. it's actually bug 28514 that resolves this further down the line.
Created attachment 127464 [details] [review]
Bug 28712: Add fallback to default for missing language template
Taking inspiration from bug 28487 to produce a fix for older versions here.. this is already resolved in 21.11 onwards by bug 28514.
I had a go at testing on 21.05, but I wasn't able to reproduce the issue.
I think the dependency is in 21.05 - we have run into this in 20.11. I have corrected the version on the bug.
(In reply to Katrin Fischer from comment #8)
> I think the dependency is in 21.05 - we have run into this in 20.11. I have
> corrected the version on the bug.
Thanks Katrin! I was able to recreate the issue on 20.11.
I still get a blank PDF - changed the default to english, also installed and de-DE, but PDF still blank.
Maybe // instead of ||.. I've not really got any 20.11's having problems at this point.. so downgrading to normal for now.
I can confirm this if fixed in master. Joubu pointed out that bug 26734 fixed it in 21.05. As 20.11 is no longer maintained, this is a WONTFIX now.