This is just an enhancement but while its base is on security, this is security too
Created attachment 123563 [details] [review] Bug 28821: (follow-up) Improve operation of button plus/less Follow-up for bug 28784. Do not remove the op select on the first row. Allow plus/less on all lines. Allow less until we have one line left. Make sure that first op is disabled and hidden with plus/less. Test plan: Search on multiple indexes on advanced search. Verify that plus/minus works as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Moving to regular Koha product now
Created attachment 124790 [details] [review] Bug 28821: (follow-up) Improve operation of button plus/less Follow-up for bug 28784. Do not remove the op select on the first row. Allow plus/less on all lines. Allow less until we have one line left. Make sure that first op is disabled and hidden with plus/less. Test plan: Search on multiple indexes on advanced search. Verify that plus/minus works as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Works fine. Maybe we should also review staff interface search page. There is actually no less button :-O
Created attachment 125331 [details] [review] Bug 28821: (follow-up) Improve operation of button plus/less Follow-up for bug 28784. Do not remove the op select on the first row. Allow plus/less on all lines. Allow less until we have one line left. Make sure that first op is disabled and hidden with plus/less. Test plan: Search on multiple indexes on advanced search. Verify that plus/minus works as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I can remove the 3 lines. That's why it was done that way. You certainly need JS code to prevent that.
(In reply to Jonathan Druart from comment #6) > I can remove the 3 lines. That's why it was done that way. You certainly > need JS code to prevent that. + if($(this).parent().parent().siblings().length < 2 ) { $('.ButtonLess').hide(); Please explain how to reproduce. Or refresh browser cache etc ?
From IRC: 14:29 < Joubu> marcelr: ok, got it. I am using ES and I am seeing a " Apply field weights to search " checkox 14:29 < Joubu> it's a sibling 14:30 < Joubu> it indeed works correctly with searchengine=zebra
Created attachment 125452 [details] [review] Bug 28821: (QA follow-up) Adjust javascript test The test did not work when SearchEngine == Elasticsearch. Test plan: Verify if it works now for Elasticsearch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 21.11, thanks to everybody involved!