Bug 28836 - Duplicated import in template plugins
Summary: Duplicated import in template plugins
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-10 11:48 UTC by Tomás Cohen Arazi
Modified: 2021-08-10 11:48 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2021-08-10 11:48:18 UTC
In template plugins, we often find double importing of the parent library:

use Template::Plugin;
use base qw( Template::Plugin );

Some of the plugins use 'base' [1] like this, and others use 'parent' (that seems to be what we should be using in this cases, as we are not ) [2].

[1] https://perldoc.perl.org/base
[2] https://perldoc.perl.org/parent#HISTORY