The automatic checkin feature introduced in bug 23207 requires a cron job. We should note that in item type setup so users don't expect the feature to start working simply because they checked the box.
Created attachment 124194 [details] [review] Bug 28913: Note cronjob on automatic return settings in itemtypes To test: 1 - go to itemtype config in Admin 2 - confirm it doesn't mention the automatic_return cron 3 - apply patch and restart 4 - confirm note now says "This feature requires the misc/cronjobs/automatic_checkin.pl cronjob. Ask your system administrator to schedule it."
Created attachment 126968 [details] [review] Bug 28913: Note cronjob on automatic return settings in itemtypes To test: 1 - go to itemtype config in Admin 2 - confirm it doesn't mention the automatic_return cron 3 - apply patch and restart 4 - confirm note now says "This feature requires the misc/cronjobs/automatic_checkin.pl cronjob. Ask your system administrator to schedule it." Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 127129 [details] [review] Bug 28913: Note cronjob on automatic return settings in itemtypes To test: 1 - go to itemtype config in Admin 2 - confirm it doesn't mention the automatic_return cron 3 - apply patch and restart 4 - confirm note now says "This feature requires the misc/cronjobs/automatic_checkin.pl cronjob. Ask your system administrator to schedule it." Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I don't know if it's a big deal but, to me, the note reads like: the cronjob is not setup correctly. Whereas we don't know and maybe no action is required.
It's phrased like the system preferences, but I understand what you mean. What if we just leave otu the "Ask..." part?
Pushed to master for 21.11, thanks to everybody involved!
(In reply to Katrin Fischer from comment #5) > It's phrased like the system preferences, but I understand what you mean. > What if we just leave otu the "Ask..." part? Sorry, didn't see your comment before I pushed it. Feel free to submit a follow-up here!
Pushed to 21.05.x for 21.05.05
Depends on Bug 23207 not in 20.11.x