Bug 28974 - Add pagination to holds queue viewer
Summary: Add pagination to holds queue viewer
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 28966
Blocks:
  Show dependency treegraph
 
Reported: 2021-09-08 15:03 UTC by Kyle M Hall
Modified: 2021-10-14 13:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28974: Add pagination to holds queue viewer (5.79 KB, patch)
2021-09-08 16:00 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Start at first page when change number of results per page (1.42 KB, patch)
2021-09-14 12:22 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Add pagination to holds queue viewer (5.84 KB, patch)
2021-09-15 06:03 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 28974: Start at first page when change number of results per page (1.47 KB, patch)
2021-09-15 06:04 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 28974: Add pagination to holds queue viewer (6.07 KB, patch)
2021-09-24 17:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Start at first page when change number of results per page (1.48 KB, patch)
2021-09-24 17:28 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Add pagination to holds queue viewer (6.34 KB, patch)
2021-09-24 18:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Start at first page when change number of results per page (1.44 KB, patch)
2021-09-24 18:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Hard code page = 1 instead of using javascript (1.36 KB, patch)
2021-09-24 18:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Add pagination to holds queue viewer (7.11 KB, patch)
2021-09-27 18:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Start at first page when change number of results per page (1.46 KB, patch)
2021-09-27 18:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Hard code page = 1 instead of using javascript (1.38 KB, patch)
2021-09-27 18:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Add pagination to holds queue viewer (7.83 KB, patch)
2021-09-28 12:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Start at first page when change number of results per page (1.46 KB, patch)
2021-09-28 12:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Hard code page = 1 instead of using javascript (1.38 KB, patch)
2021-09-28 12:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Add pagination to holds queue viewer (7.99 KB, patch)
2021-09-28 14:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Start at first page when change number of results per page (1.46 KB, patch)
2021-09-28 14:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Hard code page = 1 instead of using javascript (1.38 KB, patch)
2021-09-28 14:58 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Add pagination to holds queue viewer (9.53 KB, patch)
2021-09-28 16:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Start at first page when change number of results per page (1.46 KB, patch)
2021-09-28 16:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: Hard code page = 1 instead of using javascript (1.38 KB, patch)
2021-09-28 16:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 28974: (follow-up) Pass total number of items instead of count per page (1016 bytes, patch)
2021-10-14 13:09 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2021-09-08 15:03:54 UTC
We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.
Comment 1 Kyle M Hall 2021-09-08 16:00:48 UTC
Created attachment 124660 [details] [review]
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly
Comment 2 Katrin Fischer 2021-09-10 06:06:46 UTC
Will it still be possible to print the whole queue over multiple pages?
Comment 3 Kyle M Hall 2021-09-13 16:15:36 UTC
(In reply to Katrin Fischer from comment #2)
> Will it still be possible to print the whole queue over multiple pages?

Yes, you can choose the number of results per page.
Comment 4 Emmi Takkinen 2021-09-14 08:39:29 UTC
I think this needs some improvement. I have over 600 holds on my list. I first selected 10 rows per page and moved to page 3. Then I changed rows per page as 1000 assuming all holds would be displayed. Instead I got blank page. I had to switch back to 10 rows per page, go to page 1 and then select 1000 per page to see all of my holds. IMO it would be more user friendly to e.g. return to the first page if rows per page is changed. Otherwise this works fine.
Comment 5 Kyle M Hall 2021-09-14 12:22:55 UTC
Created attachment 124864 [details] [review]
Bug 28974: Start at first page when change number of results per page
Comment 6 Emmi Takkinen 2021-09-15 06:03:32 UTC
Created attachment 124874 [details] [review]
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 7 Emmi Takkinen 2021-09-15 06:04:09 UTC
Created attachment 124875 [details] [review]
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 8 Kyle M Hall 2021-09-24 17:27:51 UTC
Created attachment 125291 [details] [review]
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 9 Kyle M Hall 2021-09-24 17:28:03 UTC
Created attachment 125292 [details] [review]
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 10 Kyle M Hall 2021-09-24 18:06:15 UTC
Created attachment 125295 [details] [review]
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 11 Kyle M Hall 2021-09-24 18:06:24 UTC
Created attachment 125296 [details] [review]
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 12 Kyle M Hall 2021-09-24 18:06:28 UTC
Created attachment 125297 [details] [review]
Bug 28974: Hard code page = 1 instead of using javascript
Comment 13 Kyle M Hall 2021-09-27 18:09:58 UTC
Created attachment 125371 [details] [review]
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 14 Kyle M Hall 2021-09-27 18:10:09 UTC
Created attachment 125372 [details] [review]
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 15 Kyle M Hall 2021-09-27 18:10:13 UTC
Created attachment 125373 [details] [review]
Bug 28974: Hard code page = 1 instead of using javascript
Comment 16 Kyle M Hall 2021-09-28 12:37:26 UTC
Created attachment 125399 [details] [review]
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 17 Kyle M Hall 2021-09-28 12:37:41 UTC
Created attachment 125400 [details] [review]
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 18 Kyle M Hall 2021-09-28 12:37:44 UTC
Created attachment 125401 [details] [review]
Bug 28974: Hard code page = 1 instead of using javascript
Comment 19 Kyle M Hall 2021-09-28 14:57:59 UTC
Created attachment 125414 [details] [review]
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 20 Kyle M Hall 2021-09-28 14:58:18 UTC
Created attachment 125415 [details] [review]
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 21 Kyle M Hall 2021-09-28 14:58:21 UTC
Created attachment 125416 [details] [review]
Bug 28974: Hard code page = 1 instead of using javascript
Comment 22 Kyle M Hall 2021-09-28 16:20:11 UTC
Created attachment 125424 [details] [review]
Bug 28974: Add pagination to holds queue viewer

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all.

Paginating the results of the holds queue will allow this page more flexible and load more quickly.

Test Plan
1) Generate a lot of holds in the holds queue
2) Apply this patch
3) Try out the new pagination bar
4) Ensure the limit and page features function correctly

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 23 Kyle M Hall 2021-09-28 16:20:23 UTC
Created attachment 125425 [details] [review]
Bug 28974: Start at first page when change number of results per page

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 24 Kyle M Hall 2021-09-28 16:20:27 UTC
Created attachment 125426 [details] [review]
Bug 28974: Hard code page = 1 instead of using javascript
Comment 25 Nick Clemens 2021-10-14 13:09:14 UTC
Created attachment 126277 [details] [review]
Bug 28974: (follow-up) Pass total number of items instead of count per page

Before pagination the count of items was the same as the total, now they will differ

Make sure to pass $total to the template instead fo the count per page