In MARC21 XSLT files for display, many call on 'chopPunctuation' use param 'punctuation'. But this param is not used in MARC21slimUtils.xsl in 'chopPunctuation'. Strangely this param exists in MARC21slimUtils2.xsl. For example this removes ending dot in display of field 100 while 'punctuation' param contains ':,;/ '
This may be close to Bug 21303
See : > git grep '<xsl:with-param name="punctuation">' koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslimUtils.xsl:<xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslimUtils.xsl:<xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl: <xsl:with-param name="punctuation">
Created attachment 129524 [details] [review] Bug 28976 : MARC21 Dots from field 100 are omitted in the OPAC and staff client When there is some dot in field 100 (for example when the name have an initials at the end) the dot is omitted in the OPAC ans the staff interface. To test: 1- Find or create a record with a dot in field 100 2a- From the staff interface, search the catalog for your record. Observe that the dot is omitted 2b- From the staff interface, go to the detail page of your record. Observe that the dot is omitted 2c- Repeat step 2a and 2b from the OPAC 3- Apply the patch 4- Repeat step 2. Observe that the dot is now display on all the pages.
Created attachment 129525 [details] [review] retab MARC21slimUtils.xsl files replace tab with 4 spaces
*** Bug 30029 has been marked as a duplicate of this bug. ***
This works as intended with the test plan. However, now when I view search results ( OPAC or staff client ) there is often two periods. I am using koha testing docker sample data. An example is this in the 100: Dina, Anca (ed.).
Created attachment 130529 [details] example
@Lucas, thanks for testing. We need a MARC21 user here, could you continue on this patch ?
Anyone still working on this?
(In reply to Martin Renvoize from comment #9) > Anyone still working on this? You can take if you want