Bug 28976 - In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation'
Summary: In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation'
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
: 30029 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-09-08 19:52 UTC by Fridolin Somers
Modified: 2023-08-24 07:59 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28976 : MARC21 Dots from field 100 are omitted in the OPAC and staff client (16.46 KB, patch)
2022-01-17 13:37 UTC, Marion Durand
Details | Diff | Splinter Review
retab MARC21slimUtils.xsl files (21.27 KB, patch)
2022-01-17 13:41 UTC, Marion Durand
Details | Diff | Splinter Review
example (38.68 KB, image/png)
2022-02-11 23:04 UTC, Lucas Gass
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2021-09-08 19:52:55 UTC
In MARC21 XSLT files for display, many call on 'chopPunctuation' use param 'punctuation'.
But this param is not used in MARC21slimUtils.xsl in 'chopPunctuation'.
Strangely this param exists in MARC21slimUtils2.xsl.

For example this removes ending dot in display of field 100 while 'punctuation' param contains ':,;/ '
Comment 1 Fridolin Somers 2021-09-08 19:53:43 UTC
This may be close to Bug 21303
Comment 2 Fridolin Somers 2021-09-08 19:56:05 UTC
See :
 > git grep '<xsl:with-param name="punctuation">'
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl:                                                            <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl:                            <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl:                                                              <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl:                              <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl:                                                             <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl:                             <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:                    <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:                        <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:                    <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslimUtils.xsl:<xsl:with-param name="punctuation">
koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:                            <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:                        <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:                <xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslimUtils.xsl:<xsl:with-param name="punctuation">
koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl:                <xsl:with-param name="punctuation">
Comment 3 Marion Durand 2022-01-17 13:37:05 UTC
Created attachment 129524 [details] [review]
Bug 28976 : MARC21 Dots from field 100 are omitted in the OPAC and staff client

When there is some dot in field 100 (for example when the name have an initials at the end) the dot is omitted in the OPAC ans the staff interface.

To test:
1- Find or create a record with a dot in field 100
2a- From the staff interface, search the catalog for your record. Observe that the dot is omitted
2b- From the staff interface, go to the detail page of your record. Observe that the dot is omitted
2c- Repeat step 2a and 2b from the OPAC
3- Apply the patch
4- Repeat step 2. Observe that the dot is now display on all the pages.
Comment 4 Marion Durand 2022-01-17 13:41:57 UTC
Created attachment 129525 [details] [review]
retab MARC21slimUtils.xsl files

replace tab with 4 spaces
Comment 5 Lucas Gass 2022-02-11 22:56:38 UTC
*** Bug 30029 has been marked as a duplicate of this bug. ***
Comment 6 Lucas Gass 2022-02-11 23:03:58 UTC
This works as intended with the test plan. However, now when I view search results ( OPAC or staff client ) there is often two periods. I am using koha testing docker sample data.

An example is this in the 100:

Dina, Anca (ed.).
Comment 7 Lucas Gass 2022-02-11 23:04:28 UTC
Created attachment 130529 [details]
example
Comment 8 Fridolin Somers 2022-07-01 20:43:34 UTC
@Lucas, thanks for testing.
We need a MARC21 user here, could you continue on this patch ?
Comment 9 Martin Renvoize 2023-08-23 06:56:39 UTC
Anyone still working on this?
Comment 10 Fridolin Somers 2023-08-24 07:59:06 UTC
(In reply to Martin Renvoize from comment #9)
> Anyone still working on this?

You can take if you want