Bug 28996 - SendAlerts crashes on a bad email 'To'
Summary: SendAlerts crashes on a bad email 'To'
Status: REOPENED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 22343
Blocks:
  Show dependency treegraph
 
Reported: 2021-09-10 11:56 UTC by Didier Gautheron
Modified: 2024-02-06 23:18 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28996: Catch error in mail creation (4.22 KB, patch)
2021-09-24 12:20 UTC, Didier Gautheron
Details | Diff | Splinter Review
Bug 28996: Catch error in mail creation (7.28 KB, patch)
2021-09-24 14:08 UTC, Didier Gautheron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Gautheron 2021-09-10 11:56:25 UTC
If there's a bad 'To' field email create die but it isn't caught by SendQueuedMessages.
Comment 1 Didier Gautheron 2021-09-24 12:20:13 UTC
Created attachment 125238 [details] [review]
Bug 28996: Catch error in mail creation
Comment 2 Didier Gautheron 2021-09-24 14:08:10 UTC
Created attachment 125250 [details] [review]
Bug 28996: Catch error in mail creation
Comment 3 Fridolin Somers 2021-09-24 19:49:17 UTC
+1 giga
Comment 4 Jonathan Druart 2021-10-06 15:52:23 UTC

*** This bug has been marked as a duplicate of bug 28803 ***
Comment 5 Jonathan Druart 2021-10-06 15:52:49 UTC
Looks like a duplicate of bug 28803. Please reopen if I am wrong.
Comment 6 David Cook 2024-02-06 23:16:58 UTC
It looks like bug 28803 only covers part of the root problem. C4::Letters::SendAlerts still has the problem. I'll rename the bug title to be more accurate.
Comment 7 David Cook 2024-02-06 23:18:16 UTC
The patch will need to be rewriten to take into account bug 28803 but should be an easy fix overall. (I've applied the fix locally for years. At some point this year I might find the time to upstream it.)