Fix in #14599 and #8080 aren't working anymore with latest Firefox Tested with Firefox 92: 1 - Log in staff as user foo password bar 2 - Save user and password in Firefox 3 - Log out 4 - Log in again, log in pop-up must be pre-filled 3 - Open Create a new patron form 4 - At least password field is pre-filled with logged in user's credentials
Created attachment 124873 [details] [review] Bug 29025: Don't prefill userid and password in user creation form Recent Firefox versions try to prefill userid and password with logged in user credentials. To test 1 - Log in staff as user foo password bar 2 - Save user and password in Firefox 3 - Log out 4 - Log in again, log in pop-up must be pre-filled 5 - Open Create a new patron form 6 - At least password field is pre-filled with logged in user's credentials 7 - Apply patch 8 - Redo 4 and 5 9 - Userid and password fields aren't prefilled
Created attachment 124889 [details] [review] Bug 29025: Don't prefill userid and password in user creation form Recent Firefox versions try to prefill userid and password with logged in user credentials. To test 1 - Log in staff as user foo password bar 2 - Save user and password in Firefox 3 - Log out 4 - Log in again, log in pop-up must be pre-filled 5 - Open Create a new patron form 6 - At least password field is pre-filled with logged in user's credentials 7 - Apply patch 8 - Redo 4 and 5 9 - Userid and password fields aren't prefilled Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Thanks for the fix Didier, we just recently noticed that this problem was back.
Created attachment 125336 [details] [review] Bug 29025: Don't prefill userid and password in user creation form Recent Firefox versions try to prefill userid and password with logged in user credentials. To test 1 - Log in staff as user foo password bar 2 - Save user and password in Firefox 3 - Log out 4 - Log in again, log in pop-up must be pre-filled 5 - Open Create a new patron form 6 - At least password field is pre-filled with logged in user's credentials 7 - Apply patch 8 - Redo 4 and 5 9 - Userid and password fields aren't prefilled Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#preventing_autofilling_with_autocompletenew-password
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.11
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.