Bug 29055 - Focus on keyword field when subscription biblio search window opens
Summary: Focus on keyword field when subscription biblio search window opens
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2021-09-20 04:21 UTC by Aleisha Amohia
Modified: 2022-05-15 22:49 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 29055: Focus on keyword field when subscription biblio search window opens (2.39 KB, patch)
2022-05-12 15:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 29055: Focus on keyword field when subscription biblio search window opens (2.44 KB, patch)
2022-05-13 00:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 29055: Focus on keyword field when subscription biblio search window opens (2.50 KB, patch)
2022-05-15 22:49 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2021-09-20 04:21:11 UTC
To reproduce:
1. Go to Serials and Add a new subscription
2. Search for a record
3. There is only one search field (keyword), and you have to click into it to use it. It should be focussed as the window opens so the cursor starts in there.
Comment 1 Owen Leonard 2022-05-12 15:21:53 UTC
Created attachment 134929 [details] [review]
Bug 29055: Focus on keyword field when subscription biblio search window opens

This patch adds the "autofocus" attribute to the keyword field in the
popup window used to find a bibliographic record to use in a
subscription.

The same is also done for the vendor search popup.

To test, apply the patch and go to Serials -> New subscription.

- Click the "Search for vendor" link. When the "Serial subscription:
  search for vendor" window opens the cursor should automatically be in
  the vendor search field.
- Click the "Search for record" link. When the "Catalog search" window
  opens the cursor focus should automatically be in the keyword field.
Comment 2 David Nind 2022-05-13 00:51:11 UTC
Created attachment 134939 [details] [review]
Bug 29055: Focus on keyword field when subscription biblio search window opens

This patch adds the "autofocus" attribute to the keyword field in the
popup window used to find a bibliographic record to use in a
subscription.

The same is also done for the vendor search popup.

To test, apply the patch and go to Serials -> New subscription.

- Click the "Search for vendor" link. When the "Serial subscription:
  search for vendor" window opens the cursor should automatically be in
  the vendor search field.
- Click the "Search for record" link. When the "Catalog search" window
  opens the cursor focus should automatically be in the keyword field.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2022-05-15 22:39:50 UTC
Works, qa script happy, code looks good, passing QA :)
Comment 4 Victor Grousset/tuxayo 2022-05-15 22:49:10 UTC
Created attachment 135010 [details] [review]
Bug 29055: Focus on keyword field when subscription biblio search window opens

This patch adds the "autofocus" attribute to the keyword field in the
popup window used to find a bibliographic record to use in a
subscription.

The same is also done for the vendor search popup.

To test, apply the patch and go to Serials -> New subscription.

- Click the "Search for vendor" link. When the "Serial subscription:
  search for vendor" window opens the cursor should automatically be in
  the vendor search field.
- Click the "Search for record" link. When the "Catalog search" window
  opens the cursor focus should automatically be in the keyword field.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>