Prior to bug 21249, branch limits in searching were enforced based on the item homebranch. Bug 21249 introduces a syspref to control how those limits are enforced. That's good. But on update the syspref is set to limit based on BOTH homebranch and holdingbranch. That's bad. From 21249: $dbh->do(q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SearchLimitLibrary', 'both', 'homebranch|holdingbranch|both', "When limiting search results with a library or library group, use the item's home library, or holding library, or both.", 'Choice')}); Should we not make that default to homebranch in order to not silently change how searches work? This makes a *huge* difference in search results.
Created attachment 125799 [details] [review] Bug 29152: Change default value for SearchLimitLibrary to 'homebranch' Behvaiour before this option was added was 'homebranch' We should preserve this rather than introduce a change No atomic update added as liobraries may have already set/changed the value, but safer to default to previous behvaiour
Created attachment 127180 [details] [review] Bug 29152: Change default value for SearchLimitLibrary to 'homebranch' Behvaiour before this option was added was 'homebranch' We should preserve this rather than introduce a change No atomic update added as liobraries may have already set/changed the value, but safer to default to previous behvaiour Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix, no errors in testing. PQA
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Depends on Bug 21249 not in 20.11.x