Bug 29161 - Holds to pull should show item level holds only if available
Summary: Holds to pull should show item level holds only if available
Status: RESOLVED DUPLICATE of bug 29786
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 21.05
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 29148
Blocks:
  Show dependency treegraph
 
Reported: 2021-10-04 05:34 UTC by Minna Kivinen
Modified: 2022-01-06 14:53 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 29161: POC (2.90 KB, patch)
2021-12-02 14:49 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Minna Kivinen 2021-10-04 05:34:40 UTC
Holds to pull list shows now item level hold on the list if there are other items available. Item level hold should show on the list only when requested item is available.
Comment 1 Andrew Fuerste-Henry 2021-12-01 20:46:07 UTC
Changing this from Enhancement to Normal, as it is legitimately a bug rather than an enhancement.
Comment 2 Andrew Fuerste-Henry 2021-12-01 21:05:56 UTC
As an added point of confusion, if your item-level hold is on an unavailable item and Koha shows it on the Holds to Pull anyway, it will be shown as an item-level hold for some copy that is available (though Koha rightly will refuse to fill the hold with the item its sent you to pull).
Comment 3 Nick Clemens (kidclamp) 2021-12-02 14:49:08 UTC
Created attachment 128171 [details] [review]
Bug 29161: POC

This is messy - our listing of holds only grabs the first, so we cannot tell
whether we have both itemnumber and biblionumber holds.

This patch removes the limit on priority one, then checks in get_items_that_can_fill
for both item level and title level holds. I don't know how this affects the grouping for display

We also only deal with one hold at a time on this report - if there are several title level holds,
we only see it once, I guess fine, you fill that, run the report, fill the second

Test plan below fails

To test:
1 - Place an item level hold on a biblio with multiple items
2 - Run Holds to pull
3 - The hold shgows - okay
4 - Checkout the item with the hold to another patron
5 - The holds shows - not okay
6 - Apply patch
7 - The hold no longer shows
8 - Place a title level hold
9 - That hold shows
Comment 4 Andrew Fuerste-Henry 2022-01-06 14:53:36 UTC
After some testing, this issue is a side effect of bug 29786. The patch there will correct this.

*** This bug has been marked as a duplicate of bug 29786 ***