If you have reached the daily limit (bug 27945) and article request are not possible, the error will be "daily limit reached" when it should be "No article requests can be made for this record" Step to recreate: - Turn the syspref "ArticleRequests" on - Circ rule "Article requests" => No - "Default article requests limits" for your patron's category => 0 /cgi-bin/koha/opac-request-article.pl?biblionumber=1 => "You reached your article requests daily limit." The ELSIF ELSE in opac-request-article.tt need to be improved.
Created attachment 125893 [details] [review] Bug 29169: Fix wrong terminology when article request is not available Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
+ [% SWITCH error_message %] + [% CASE 'article_request_limit_reached' %]You reached your open article requests limit. + [% CASE 'article_request_unhandled_exception' %]An error has occurred. + [% END %] No blocker, but there is no fallback.
(In reply to Marcel de Rooy from comment #2) > + [% SWITCH error_message %] > + [% CASE 'article_request_limit_reached' > %]You reached your open article requests limit. > + [% CASE 'article_request_unhandled_exception' > %]An error has occurred. > + [% END %] > > No blocker, but there is no fallback. Which there wasnt either ;)
Created attachment 125919 [details] [review] Bug 29169: Fix wrong terminology when article request is not available Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial edit. SO + QA combined
Pushed to master for 21.11, thanks to everybody involved!