Hang on
Created attachment 125736 [details] [review] Bug 29175: finishreceive: Replace , by ; This certainly is one of my shortest fixes ever ;) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Taking the liberty to pass this thru QA myself :)
(In reply to Marcel de Rooy from comment #2) > Taking the liberty to pass this thru QA myself :) How dare you.
I laughed when I read the original name, but now I'm curious how you even noticed this one. Perl critic? I didn't even know until today that you could use a comma to put multiple calls into one single statement... at least not in this way I guess.
(In reply to David Cook from comment #4) > I laughed when I read the original name, but now I'm curious how you even > noticed this one. Sharp sight, no lenses :) > I didn't even know until today that you could use a comma to put multiple > calls into one single statement... at least not in this way I guess. You shouldnt do it. Here are a few sad examples: use Modern::Perl; my $a = 1, ( print "$a \n" ); Use of uninitialized value $a in concatenation (.) or string at zz line 2. use Modern::Perl; my $c = 1, ( print "$c \n" ); Global symbol "$c" requires explicit package name (did you forget to declare "my $c"?) at zz line 2. => Please tell me the difference? use Modern::Perl; my $a = 1, my $b = 2, $a++, $b--, ( print "$a $b\n" ); 1 -1 => Clear enough, haha
That's crazy, I really would like to know the difference between $a and $c...
Created attachment 125778 [details] [review] Bug 29175: finishreceive: Replace , by ; This certainly is one of my shortest fixes ever ;) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.11
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.