In MARC21slim2OPACResults.xsl there are 2 class that are rendered like this: $class_block $class_status I'm pretty sure those are invalid HTML class names. I also suspect this was a typo.
Created attachment 125985 [details] [review] Bug 29199: fix bad class names Go to OPAC results page and inscept the page. See the class names inside ItemSummary with class names containing a $ Apply patch, restart things Class names are the same but without the leading $
Created attachment 125988 [details] [review] Bug 29199: fix bad class names Go to OPAC results page and inscept the page. See the class names inside ItemSummary with class names containing a $ Apply patch, restart things Class names are the same but without the leading $ Signed-off-by: David Nind <david@davidnind.com>
I am not sure this patch is correct. The idea here seems to have been that the XSLT variables should have been replaced by different values depending on context. This patch just makes them static. We should have a deeper look.
I checked against an older version, and this class names should probably contain things like ItemBranch, CallNumberAndLabel. So I've ruled out a typo here, definitely needs more investigation.
Created attachment 126030 [details] [review] Bug 29199: Fix parameters of ListCallNumbers [1] ItemBranch should have been passed with quotes. [2] You cannot use $x as class name, you need to use xsl:attribute. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Lucas or David, please have a look again.
Created attachment 126132 [details] [review] Bug 29199: Fix parameters of ListCallNumbers [1] ItemBranch should have been passed with quotes. [2] You cannot use $x as class name, you need to use xsl:attribute. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(In reply to Marcel de Rooy from comment #6) > Lucas or David, please have a look again. Thanks for the patch Marcel!
Created attachment 126327 [details] [review] Bug 29199: Fix parameters of ListCallNumbers [1] ItemBranch should have been passed with quotes. [2] You cannot use $x as class name, you need to use xsl:attribute. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed (inadvertently) to master for 21.11.00
(In reply to Jonathan Druart from comment #10) > Pushed (inadvertently) to master for 21.11.00 ?
(In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #10) > > Pushed (inadvertently) to master for 21.11.00 > > ? It was signed off when I pushed it, I forgot to remove from my branch (applied on cascade after I applied bug 28831).