TO recreate: 1. Set BlockReturnOfLostItems to 'don't block' 2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' 3. Check something out and then mark it as lost. 4. Check the item in and notice that the modal popup says "A refund has been applied to the borrowing patron's account." 5. This is not true, a refund is not issued. Pretty sure this is caused by Bug 23091
Looks related to commit bb7a865fb8142252732a5fb255a1db95fe92c3e0 Bug 18501: set the is_refunded flag as internal var
Created attachment 126476 [details] [review] Bug 29221: Correctly display refund info 2132 $messages->{'LostItemFeeRefunded'} = $updated_item->{_refunded}; But, in returns.pl: 495 elsif ( $code eq 'LostItemFeeRefunded' ) { 496 $template->param( LostItemFeeRefunded => 1 ); 497 } 1. Set BlockReturnOfLostItems to 'don't block' 2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' 3. Check something out and then mark it as lost. 4. Check the item in => No message to tell there was a refund
Created attachment 126478 [details] [review] Bug 29221: Correctly display refund info 2132 $messages->{'LostItemFeeRefunded'} = $updated_item->{_refunded}; But, in returns.pl: 495 elsif ( $code eq 'LostItemFeeRefunded' ) { 496 $template->param( LostItemFeeRefunded => 1 ); 497 } 1. Set BlockReturnOfLostItems to 'don't block' 2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' 3. Check something out and then mark it as lost. 4. Check the item in => No message to tell there was a refund Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch, signing off.
Created attachment 126557 [details] [review] Bug 29221: Correctly display refund info 2132 $messages->{'LostItemFeeRefunded'} = $updated_item->{_refunded}; But, in returns.pl: 495 elsif ( $code eq 'LostItemFeeRefunded' ) { 496 $template->param( LostItemFeeRefunded => 1 ); 497 } 1. Set BlockReturnOfLostItems to 'don't block' 2. Make sure your 'Default lost item fee refund on return policy' circ rule is set to 'Leave lost item charge' 3. Check something out and then mark it as lost. 4. Check the item in => No message to tell there was a refund Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!