Created attachment 126270 [details] Display issue Any .message div has it's width overridden down to 55% compared to .dialog divs that have 65% width. This leads to disparity in display.
Created attachment 126272 [details] [review] Bug 29244: Move message inside dialog and remove width This patch moves the message css rules inside the dialog ruleset to clarify their intention and removes the width so it inherits from the dialog class.
Created attachment 126273 [details] [review] Bug 29244: Add dialog class where missing in print-notices.tt The print notices template had it's own implimentation of a message dialog. To make it consistent with other area's, we should add the dialog class.
Created attachment 126291 [details] [review] Bug 29244: Move message inside dialog and remove width This patch moves the message css rules inside the dialog ruleset to clarify their intention and removes the width so it inherits from the dialog class. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 126292 [details] [review] Bug 29244: Add dialog class where missing in print-notices.tt The print notices template had it's own implimentation of a message dialog. To make it consistent with other area's, we should add the dialog class. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 126619 [details] [review] Bug 29244: Move message inside dialog and remove width This patch moves the message css rules inside the dialog ruleset to clarify their intention and removes the width so it inherits from the dialog class. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 126620 [details] [review] Bug 29244: Add dialog class where missing in print-notices.tt The print notices template had it's own implimentation of a message dialog. To make it consistent with other area's, we should add the dialog class. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.11
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.