Bug 29247 - Enable staff to see whether a patron has a password or not
Summary: Enable staff to see whether a patron has a password or not
Status: REOPENED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-15 09:35 UTC by Alexander Borkowski
Modified: 2022-02-26 21:58 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Borkowski 2021-10-15 09:35:33 UTC
In the staff client at members/moremember.pl, a patron's password is always shown as a number of stars, even for patrons which do not have a password set.

While there are provisions to handle unset passwords in koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt these are not effective. It is checked whether the patron.password field is false/empty or not. However, Koha::Patron::store always at least writes an exclamation mark in that field to mark the password invalid. So the field is never really empty, the condition being checked is always false, and hence the staff client never shows that a patron does not have a password set.
Comment 1 Erica Rohlfs 2021-10-21 20:18:55 UTC
I'm new to Koha Bug Wrangling and setting duplicates, so everyone please forgive me if I do this wrong and thank you for your patience. I think this may be a duplicate or an extension of why the functionality will be useful/important of 24949.

*** This bug has been marked as a duplicate of bug 24949 ***
Comment 2 Alexander Borkowski 2021-10-25 08:10:42 UTC
I am new to Koha Bug Wrangling as well but think this issue is not a duplicate of bug 24949. 

Our staff have requested to be able to see whether a patron has set a password or not. This is useful as it can happen that patrons have a patron record but not set a password yet. Staff can then advise the patron in this situation on how to set their password. I found that there are provisions in Koha's code already for showing whether a patron has a password set or not so but they are not working properly and I indicated the reason for that. So this is an issue for the current Koha code.

Bug 24949 is a request for a new feature. And while I agree that being able to see the actual password might be very useful in some contexts (not in ours - that would never be permitted) to me it is a different issue.
Comment 3 Katrin Fischer 2022-02-26 21:58:15 UTC
I think we set borrowers.password to "" or ! when not set, so it should be possible to use that information for a visual clue.