Bug 29385 - Add missing cash register support to SIP2
Summary: Add missing cash register support to SIP2
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 23321 24828
Blocks: 13985
  Show dependency treegraph
 
Reported: 2021-11-01 14:20 UTC by Martin Renvoize
Modified: 2021-12-02 12:54 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 29385: Catch register_id for payments against fees (1.36 KB, patch)
2021-11-01 14:23 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 29385: Catch register_id for payments against fees (1.43 KB, patch)
2021-11-01 16:32 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29385: [ALTERNATIVE] Catch register_id for payments against fees (2.18 KB, patch)
2021-12-02 12:53 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2021-11-01 14:20:43 UTC
+++ This bug was initially created as a clone of Bug #24828 +++

We add support for defining cash registers for SIP with bug 24828, however, we missed the case when specific fees are being paid.
Comment 1 Martin Renvoize 2021-11-01 14:23:14 UTC
Created attachment 127173 [details] [review]
Bug 29385: Catch register_id for payments against fees

This patch adds the missing cash_register definition in the call to pay
with a set of lines defined.
Comment 2 Kyle M Hall 2021-11-01 16:32:22 UTC
Created attachment 127178 [details] [review]
Bug 29385: Catch register_id for payments against fees

This patch adds the missing cash_register definition in the call to pay
with a set of lines defined.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Jonathan Druart 2021-12-02 12:53:15 UTC
Created attachment 128159 [details] [review]
Bug 29385: [ALTERNATIVE] Catch register_id for payments against fees
Comment 4 Jonathan Druart 2021-12-02 12:54:24 UTC
To prevent such problems from happening again I would prefer a version that will not duplicate code. But hard to provide patch and be confident in it as this code is not covered by tests.