I'd like to make three changes to the output of search results from the bibliographic reservoir: - Make it a configurable DataTable. - Remove unused columns: the date and edition columns are not in the query so will never have data. - Add a column for import date.
Created attachment 127216 [details] [review] Bug 29391: Improve output of reservoir search This patch makes the cataloging reservoir search results a configurable DataTable. The empty edition and date columns are removed, and an import data column is added. To test, apply the patch and go to Cataloging. - Perform a cataloging search which will return results from the reservoir. - The table of reservoir search results should be a DataTable with paging, navigation, filtering, column configuration, etc. - Confirm that all DataTable controls work correctly. - Go to Administration -> Table settings -> Cataloging -> addbooks. - Try modifying the default configuration and confirm that the settings take effect.
Created attachment 127327 [details] [review] Bug 29391: Improve output of reservoir search This patch makes the cataloging reservoir search results a configurable DataTable. The empty edition and date columns are removed, and an import data column is added. To test, apply the patch and go to Cataloging. - Perform a cataloging search which will return results from the reservoir. - The table of reservoir search results should be a DataTable with paging, navigation, filtering, column configuration, etc. - Confirm that all DataTable controls work correctly. - Go to Administration -> Table settings -> Cataloging -> addbooks. - Try modifying the default configuration and confirm that the settings take effect. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Very nice update. I especially like that the import date was added.
- copyrightdate => $resultsbr->{copyrightdate}, - editionstatement => $resultsbr->{editionstatement}, This is correct, columns were always empty.
Created attachment 128567 [details] [review] Bug 29391: Improve output of reservoir search This patch makes the cataloging reservoir search results a configurable DataTable. The empty edition and date columns are removed, and an import data column is added. To test, apply the patch and go to Cataloging. - Perform a cataloging search which will return results from the reservoir. - The table of reservoir search results should be a DataTable with paging, navigation, filtering, column configuration, etc. - Confirm that all DataTable controls work correctly. - Go to Administration -> Table settings -> Cataloging -> addbooks. - Try modifying the default configuration and confirm that the settings take effect. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Thanks a lot Owen for release notes :D