The "Search to hold" feature doesn't work for patrons without cardnumbers. To recreate: - create a patron without a cardnumber - from the patron record, click "Search to hold" - perform a search - in your search results, note the option "Place hold for [your patron name]()" - click "Place hold for [your patron name]()", see it takes you to request.pl without a patron selected - on request.pl, search for your patron by name and confirm you're able to place a hold that way, even without a cardnumber This feature shouldn't rely on cardnumber when cardnumber is not assumed to be required in all systems.
Created attachment 127782 [details] [review] Bug 29396: Make 'Search to hold' work for patron without cardnumber
This patch may work, but there will be a side-effect. If patron A without a cardnumber has a borrowernumber set to the value of the cardnumber of patron B, B will be returned when "Place hold for A" will be clicked. To prevent that a follow-up is needed to pass 2 distinct variables to request.pl (one for cardnumber and one for borrowernumber). More logic will be needed in .tt files.