The update does not check for the existence of the foreign key before deleting it Additionally we have seen many sites with problematic data that stops the update, will offer a check for what we have seen here
Created attachment 127275 [details] [review] Bug 29409: Check for existence of constraint before deletion https://bugs.koha-community.org/show_bug.cgi?id=29049
Created attachment 127276 [details] [review] Bug 29409: Check for data that violates a constraint to avoid update problems https://bugs.koha-community.org/show_bug.cgi?id=29049
Created attachment 139931 [details] [review] Bug 29409: Check for existence of constraint before deletion https://bugs.koha-community.org/show_bug.cgi?id=29049 Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Created attachment 139932 [details] [review] Bug 29409: Check for data that violates a constraint to avoid update problems https://bugs.koha-community.org/show_bug.cgi?id=29049 Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Created attachment 140481 [details] [review] Bug 29409: Check for existence of constraint before deletion Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 140482 [details] [review] Bug 29409: Check for data that violates a constraint to avoid update problems Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great work, Passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.07 release
applied to 21.11 for 21.11.14
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved.