In bug 15812 the code was switched to redirect to members.pl if a single hit was not found by barcode. The members results page redirects to moremember if a single result is returned to the template. In the case of a 'circsearch' we should redirect to checkout, not member details
Created attachment 127287 [details] [review] Bug 29411: Redirect to circulation if circsearch is true TO test: 1 - Have a patron with a unique surname i.e. Acosta 2 - Enter the surename into 'Search patrons' box on staff homepage 3 - You are redirected to 'members/moremember.pl' 4 - Enter the surname into 'Check out' box at top of page 5 - You are redirected to 'members/moremember.pl' 6 - Apply patch 7 - Enter the surename into 'Search patrons' box on staff homepage 8 - You are redirected to 'members/moremember.pl' 9 - Enter the surname into 'Check out' box at top of page 10 - You are redirected to 'circ/circulationr.pl'
I see one issue with this: If you open the Patrons page and use the sidebar form to search, a single result redirects to circulation instead of details. I don't think this would make my staff complain at all but I think it's not what is technically expected.
Created attachment 127293 [details] [review] Bug 29411: Redirect to circulation if circsearch is true TO test: 1 - Have a patron with a unique surname i.e. Acosta 2 - Enter the surename into 'Search patrons' box on staff homepage 3 - You are redirected to 'members/moremember.pl' 4 - Enter the surname into 'Check out' box at top of page 5 - You are redirected to 'members/moremember.pl' 6 - Apply patch 7 - Enter the surename into 'Search patrons' box on staff homepage 8 - You are redirected to 'members/moremember.pl' 9 - Enter the surname into 'Check out' box at top of page 10 - You are redirected to 'circ/circulationr.pl'
Created attachment 127294 [details] [review] Bug 29411: Redirect to circulation if circsearch is true TO test: 1 - Have a patron with a unique surname i.e. Acosta 2 - Enter the surename into 'Search patrons' box on staff homepage 3 - You are redirected to 'members/moremember.pl' 4 - Enter the surname into 'Check out' box at top of page 5 - You are redirected to 'members/moremember.pl' 6 - Apply patch 7 - Enter the surename into 'Search patrons' box on staff homepage 8 - You are redirected to 'members/moremember.pl' 9 - Enter the surname into 'Check out' box at top of page 10 - You are redirected to 'circ/circulation.pl' Signed-off-by: Owen <oleonard@myacpl.org>
Created attachment 127323 [details] [review] Bug 29411: Redirect to circulation if circsearch is true TO test: 1 - Have a patron with a unique surname i.e. Acosta 2 - Enter the surename into 'Search patrons' box on staff homepage 3 - You are redirected to 'members/moremember.pl' 4 - Enter the surname into 'Check out' box at top of page 5 - You are redirected to 'members/moremember.pl' 6 - Apply patch 7 - Enter the surename into 'Search patrons' box on staff homepage 8 - You are redirected to 'members/moremember.pl' 9 - Enter the surname into 'Check out' box at top of page 10 - You are redirected to 'circ/circulation.pl' Signed-off-by: Owen <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All works as expected, nice fix. Passing QA
Pushed to master for 21.11, thanks to everybody involved!
Any chance we can get a 21.05 backport of this one?
I agree with Lucas, can we get this back ported to 21.05?