When closing budgets, we get an error trace : Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_admin_aqbudgetperiods_2epl::GetBudgetHierarchy called at /kohadevbox/koha/admin/aqbudgetperiods.pl line 230 admin/aqbudgetperiods. isn't calling GetBudgetHierarchy at line 58.
Created attachment 127399 [details] [review] Bug 29429: Cannot close budgets Adds GetBudgetHierarchy to the functions called by C4::Budgets Plan : 1. Create a budget with a random amount, save it. 2. Try to close the budget. 3. You should get an Error Trace. 4. Apply the patch 5. Close the budget again 6. It should work.
Created attachment 127408 [details] [review] Bug 29429: Cannot close budgets Adds GetBudgetHierarchy to the functions called by C4::Budgets Plan : 1. Create a budget with a random amount, save it. 2. Try to close the budget. 3. You should get an Error Trace. 4. Apply the patch 5. Close the budget again 6. It should work. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Very trivial fix to the issue caused by bug 17600, moving to PQA directly.
Florian, please have a look at this wiki page https://wiki.koha-community.org/wiki/Commit_messages The commit message is often different from the bug title. Your commit message must describe what your patch does, when the bug report title is describing the problem.
(In reply to Jonathan Druart from comment #4) > Florian, please have a look at this wiki page > https://wiki.koha-community.org/wiki/Commit_messages > The commit message is often different from the bug title. Your commit > message must describe what your patch does, when the bug report title is > describing the problem. Ah, thank you Jonathan. Very new to Koha and Bugzilla here, I'll work on my mistakes! :D
Pushed to master for 21.11, thanks to everybody involved!
Congratulations, Florian, for your first patch pushed! :)