Bug 29438 - Importing a record with an ISBN13 with no ISBN10 counterpart does not save the ISBN
Summary: Importing a record with an ISBN13 with no ISBN10 counterpart does not save th...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-08 19:41 UTC by Nick Clemens (kidclamp)
Modified: 2023-12-07 21:09 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2021-11-08 19:41:50 UTC 
When importing a record we call 'NormalizeISBN'

This routine returns nothing when an ISBN13 cannot be converted to an ISBN10 - we should have a fallback to return the original value
Comment 1 Lucas Gass (lukeg) 2023-12-07 21:09:32 UTC 
Any ISBN prefixed with 979 cannot be converted to an ISBN10. An 979 ISBN will also not pass the check here:

if ( $isbn && $isbn->is_valid() ) 

  
For example:

use Business::ISBN; 
my $isbn = Business::ISBN->new(9798986969305); 
warn Data::Dumper::Dumper($isbn->is_valid);

this returns an empty string for $isbn->is_valid