Bug 29490 - Preview for more notices
Summary: Preview for more notices
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 17981
Blocks:
  Show dependency treegraph
 
Reported: 2021-11-16 10:09 UTC by Martin Renvoize (ashimema)
Modified: 2024-09-02 13:07 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 29490: Add preview for HOLD (3.16 KB, patch)
2024-09-02 13:07 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2021-11-16 10:09:35 UTC
It would be great to have the preview option available on more notices.. currently, it's limited to CHECKIN, CHECKOUT and HOLD_SLIP.
Comment 1 Lisette Scheer 2023-11-16 21:07:52 UTC
Yes, this would be especially helpful for new libraries coming to Koha who need to test notices before crons are turned on.

You can do it by running the message queue in a very targeted way, but that takes more back end work, making it less accessible to libraries. 

Also, changes to overdue notices need to wait until the overdues run overnight to make sure nothing goes wrong.
Comment 2 Katrin Fischer 2023-11-16 21:56:03 UTC
For a workaround when testing SendAllEmailsTo could be helpful.
Comment 3 Mollie Myers 2024-08-14 20:05:49 UTC
Not being able to preview or test these prior to "going live" with them currently causes undue stress and anxiety on those of us changing the notices and we fear breaking legit notices that are going to other patrons. This would be a fantastic advancement for being able to preview notices prior to confirming those changes.
Comment 4 George Williams (NEKLS) 2024-08-15 15:53:19 UTC
Library staff should be able to preview all notices and slips without any work-arounds or need for a testing environment.
Comment 5 Katrin Fischer 2024-08-16 12:12:04 UTC
(In reply to George Williams (NEKLS) from comment #4)
> Library staff should be able to preview all notices and slips without any
> work-arounds or need for a testing environment.

The problem is that you can't generate a preview of the notices without data. With TT you can potentially pull date from almost everywhere in the system. 

Just saying, this is not something that's easily solved.
Comment 6 David Cook 2024-08-18 23:18:32 UTC
(In reply to Katrin Fischer from comment #5)
> (In reply to George Williams (NEKLS) from comment #4)
> > Library staff should be able to preview all notices and slips without any
> > work-arounds or need for a testing environment.
> 
> The problem is that you can't generate a preview of the notices without
> data. With TT you can potentially pull date from almost everywhere in the
> system. 
> 
> Just saying, this is not something that's easily solved.

I've been thinking about that... 

We can't generate a perfect preview without data, but we could preview a lot of the notice. I've had librarians just want to check if their HTML/CSS is right regardless of the data passed into the notice. 

Maybe we could have a confirm box where someone tries to preview without data we could say "Warning! You have not provided any data. Preview may not fully resemble actual notice." or something like that.

I don't know. Just a thought I've had lately.
Comment 7 Katrin Fischer 2024-08-19 07:43:08 UTC
We could do that, but it might not include the most critical, like a view of a list of items.

I wonder if we could do a pop-up form for people to enter some information about objects used. Like if it uses a borrower-Object, ask for a borrowernumber... but of course that would add a lot of additional complexity.
Comment 8 David Cook 2024-08-20 01:42:20 UTC
(In reply to Katrin Fischer from comment #7)
> We could do that, but it might not include the most critical, like a view of
> a list of items.
> 
> I wonder if we could do a pop-up form for people to enter some information
> about objects used. Like if it uses a borrower-Object, ask for a
> borrowernumber... but of course that would add a lot of additional
> complexity.

I suppose another option could be something like the TestBuilder. Maybe a NoticeBuilder that creates fake objects with fake data, although that might have limited utility for complex cases.

But maybe not a bad starting point.
Comment 9 Jonathan Druart 2024-09-02 13:07:25 UTC
Which one would be useful? It is straighforward but need to be done one by one. Added "HOLD" to show how easy it is (and it's certainly not as easy for all of the notice templates ofc).
Comment 10 Jonathan Druart 2024-09-02 13:07:41 UTC
Created attachment 170940 [details] [review]
Bug 29490: Add preview for HOLD