Bug 29537 - Simplify auto-renewal code in CanBookBeRenewed
Summary: Simplify auto-renewal code in CanBookBeRenewed
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Joonas Kylmälä
QA Contact: Testopia
URL:
Keywords:
Depends on: 29474 29476
Blocks: 29623
  Show dependency treegraph
 
Reported: 2021-11-20 11:52 UTC by Joonas Kylmälä
Modified: 2021-12-15 10:38 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 29537: Remove unnecessary if-else checks for soonest renew date (1.46 KB, patch)
2021-11-20 11:56 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 29537: Remove unnecessary if-else checks for soonest renew date (1.46 KB, patch)
2021-11-20 11:59 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 29537: Remove unnecessary if-else checks for soonest renew date (1.51 KB, patch)
2021-11-29 21:38 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Kylmälä 2021-11-20 11:52:41 UTC

    
Comment 1 Joonas Kylmälä 2021-11-20 11:56:01 UTC Comment hidden (obsolete)
Comment 2 Joonas Kylmälä 2021-11-20 11:59:28 UTC
Created attachment 127902 [details] [review]
Bug 29537: Remove unnecessary if-else checks for soonest renew date

GetSoonestRenewDate() calculates the renewal due date now also
correctly for auto-renewals after the fixes from bug 29476 so we don't
have to add any if-else checks because of it being buggy anymore.

To test:
 1) prove t/db_dependent/Circulation.t
Comment 3 David Nind 2021-11-29 21:38:11 UTC
Created attachment 128095 [details] [review]
Bug 29537: Remove unnecessary if-else checks for soonest renew date

GetSoonestRenewDate() calculates the renewal due date now also
correctly for auto-renewals after the fixes from bug 29476 so we don't
have to add any if-else checks because of it being buggy anymore.

To test:
 1) prove t/db_dependent/Circulation.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Jonathan Druart 2021-12-15 10:38:36 UTC
No longer apply correctly.