Created attachment 128081 [details] [review] Bug 29591: Add autorenew_checkouts column to preferences json Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature. When the column chooser was added, this column was not included. To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Will try to QA very soon. Thx
Note that I am suggesting to remove borrowers.json on bug 29695.
Created attachment 128558 [details] [review] Bug 29591: Add autorenew_checkouts column to preferences json Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature. When the column chooser was added, this column was not included. To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Jonathan Druart from comment #3) > Note that I am suggesting to remove borrowers.json on bug 29695. Thats great. But no reason to skip this patch. This works and can be backported as well.
(In reply to Marcel de Rooy from comment #5) > (In reply to Jonathan Druart from comment #3) > > Note that I am suggesting to remove borrowers.json on bug 29695. > > Thats great. But no reason to skip this patch. This works and can be > backported as well. Of course, it was just something I wanted to highlight here. I have rebased the patches on top of this one.
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.02
Pushed to 21.05.x for 21.05.08
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.