Created attachment 128110 [details] Screen grab showing the transition from sidebar to collapsed menu (19.11.x) We have some JS in the OPAC which is supposed to help gracefully hide and show the OPAC search results facets menu at narrower browser widths. It was working in 19.11.x At some point this was broken and the menu shows below the search results.
Created attachment 129900 [details] [review] Bug 29603: Fix responsive behavior of facets menu in OPAC search results The OPAC was originally featured a search results facets box that would collapse at narrower browser widths and show a "Refine your search" link under the breadcrumbs menu. At some point this broke, with the "Refine your search" link appearing at the bottom instead. This patch revises the page to restore the previous behavior. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform catalog search in the OPAC which will return multiple results. - View the page at various browser widths. At narrower widths the facets menu should appear as a "collapsed" box with a "Refine your search" link. - Clicking the link should toggle the facets menu visibility.
Created attachment 129967 [details] [review] Bug 29603: Fix responsive behavior of facets menu in OPAC search results The OPAC was originally featured a search results facets box that would collapse at narrower browser widths and show a "Refine your search" link under the breadcrumbs menu. At some point this broke, with the "Refine your search" link appearing at the bottom instead. This patch revises the page to restore the previous behavior. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform catalog search in the OPAC which will return multiple results. - View the page at various browser widths. At narrower widths the facets menu should appear as a "collapsed" box with a "Refine your search" link. - Clicking the link should toggle the facets menu visibility. Signed-off-by: David Nind <david@davidnind.com>
This is blocked by the dependent patch still awaiting sign-off.
Back in queue :)
Created attachment 130578 [details] [review] Bug 29603: Fix responsive behavior of facets menu in OPAC search results The OPAC was originally featured a search results facets box that would collapse at narrower browser widths and show a "Refine your search" link under the breadcrumbs menu. At some point this broke, with the "Refine your search" link appearing at the bottom instead. This patch revises the page to restore the previous behavior. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform catalog search in the OPAC which will return multiple results. - View the page at various browser widths. At narrower widths the facets menu should appear as a "collapsed" box with a "Refine your search" link. - Clicking the link should toggle the facets menu visibility. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
*** Bug 30841 has been marked as a duplicate of this bug. ***
Btw, this looks like it's needed in 20.11 and 21.11 at least as well.
Created attachment 135367 [details] [review] Bug 29603: [21.11.x] Fix responsive behavior of facets menu in OPAC search results The OPAC was originally featured a search results facets box that would collapse at narrower browser widths and show a "Refine your search" link under the breadcrumbs menu. At some point this broke, with the "Refine your search" link appearing at the bottom instead. This patch revises the page to restore the previous behavior. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform catalog search in the OPAC which will return multiple results. - View the page at various browser widths. At narrower widths the facets menu should appear as a "collapsed" box with a "Refine your search" link. - Clicking the link should toggle the facets menu visibility. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Owen Leonard from comment #9) > Created attachment 135367 [details] [review] [review] > Bug 29603: [21.11.x] Fix responsive behavior of facets menu in OPAC search > results This appears to apply cleanly to 21.05.x too.
Created attachment 135368 [details] [review] Bug 29603: [20.11.x] Fix responsive behavior of facets menu in OPAC search results The OPAC was originally featured a search results facets box that would collapse at narrower browser widths and show a "Refine your search" link under the breadcrumbs menu. At some point this broke, with the "Refine your search" link appearing at the bottom instead. This patch revises the page to restore the previous behavior. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Perform catalog search in the OPAC which will return multiple results. - View the page at various browser widths. At narrower widths the facets menu should appear as a "collapsed" box with a "Refine your search" link. - Clicking the link should toggle the facets menu visibility. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Note, I got a request for oldoldstable (21.05.x) will try to backport when it will be in oldstable.
Wait, this has been clearly missed in the last cycle. So it won't happen by itself. Email sent to Arthur for 21.11.x backport.
applied to 21.11.x for 21.11.14
Backported: Pushed to 21.05.x branch for the upcoming release (21.05.21) Nothing to document it seems, marking resolved.