If EasyAnalyticalRecords is enabled, items from host records should be included in the XML. Otherwise, OPAC search results show no items.
Created attachment 128118 [details] [review] Bug 29606: Include items from host record in XML for XSLT processing If EasyAnalyticalRecords is enabled, items from host records should be included in the XML. Otherwise, OPAC search results show no items. Test plan: 0. Do not apply the patch yet 1. Enable syspref EasyAnalyticalRecords and set OPACXSLTResultsDisplay to 'default' 2. Create a biblio record with title "parent" and create an item with a barcode for this biblio 3. Create a biblio record with title "child" with no items. On the biblio detail page, in the toolbar, click "Edit -> Link to host record" and enter the barcode for the item you created at step 2 4. Duplicate this biblio record, to be sure you will have at least two results with the search "child" (and not be redirected to the detail page) 5. Make sure your search index (zebra or elasticsearch) is up to date 6. Go to OPAC and search "child". You should see two results, no items. Click on one of them. On the detail page you should see one item (the one from the host record) 7. Apply the patch 8. Go to OPAC and search "child". You should now see one item (the same item) for each result.
Created attachment 137450 [details] [review] Bug 29606: Include items from host record in XML for XSLT processing If EasyAnalyticalRecords is enabled, items from host records should be included in the XML. Otherwise, OPAC search results show no items. Test plan: 0. Do not apply the patch yet 1. Enable syspref EasyAnalyticalRecords and set OPACXSLTResultsDisplay to 'default' 2. Create a biblio record with title "parent" and create an item with a barcode for this biblio 3. Create a biblio record with title "child" with no items. On the biblio detail page, in the toolbar, click "Edit -> Link to host record" and enter the barcode for the item you created at step 2 4. Duplicate this biblio record, to be sure you will have at least two results with the search "child" (and not be redirected to the detail page) 5. Make sure your search index (zebra or elasticsearch) is up to date 6. Go to OPAC and search "child". You should see two results, no items. Click on one of them. On the detail page you should see one item (the one from the host record) 7. Apply the patch 8. Go to OPAC and search "child". You should now see one item (the same item) for each result. Signed-off-by: David Nind <david@davidnind.com>
Can you add a unit test for the change to buildKohaItemsNamespace?
This could slow down the (already slow) search results a lot...
At a minimum, I'd say this should be wrapped in a system preference.
Maybe use Koha::Biblio->host_items()
This still needs a system preference defaulting to "off"...
(In reply to David Cook from comment #7) > This still needs a system preference defaulting to "off"... +1